-
Notifications
You must be signed in to change notification settings - Fork 604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make guest username, uid, home directory configurable #2827
Conversation
bc70c89
to
6279d7a
Compare
I recommend using "Hide whitespace" for reviewing this PR, especially for |
This comment was marked as resolved.
This comment was marked as resolved.
In terms of features, it probably would be more useful to have "groups" (extra groups) than "gid" (not used so much) |
I don't know how we would set up ssh without knowing the username. If we can figure this out, then I think we should support this. |
I have removed all code related to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The go name and the yaml name are inconsistent.
I'm wondering if |
I believe I've addressed all feedback now, PTAL There are 2 open issues that should probably be done "later":
|
Also disallows the "admin" username by default (because it is a builtin user in Ubuntu), but can be overridden by setting it explicitly in lima.yaml. Signed-off-by: Jan Dubois <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I don't actually know the use case for GECOS (even $ lima pinky $USER
Login Name TTY Idle When Where
anders Anders pts/0 2024-11-02 09:27 192.168.5.2 For the templates though, no idea. |
Also disallows the "admin" username by default (because it is a builtin user in Ubuntu), but can be overridden by setting it explicitly in lima.yaml.
Another change is that
{{.User}}
and{{.UID}}
in host templates now expand to the host values and not the guest values. Note that on Windows the host user is something likerunner\runneradmin
and host uid something likeS-1-5-21-2897396845-3571823323-1290545657-500
(on GitHub runner).Setting
home
andcomment
does not work yet withalpine-iso
becauselima-init
hardcodes the home directory to/home/$USER.linux
and doesn't set the comment at all (implemented in lima-vm/alpine-lima#134).Fixes #2117
Fixes #2037
Implements #2622
Replaces #2378