Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut down builder #235

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Cut down builder #235

merged 5 commits into from
Jan 5, 2022

Conversation

madig
Copy link
Collaborator

@madig madig commented Jan 5, 2022

Reduces OutlineBuilder to the minimum and moves the responsibilities of GlpyhBuilder back into the parser.

Closes #95.

@github-actions
Copy link

github-actions bot commented Jan 5, 2022

🗜 Bloat check ⚖️

Comparing 5c19741 against 61999a6

target old size new size difference
target/release/examples/load_save 1.9 MB 1.88 MB -18.6 KB (-0.96%)
target/debug/examples/load_save 8.6 MB 8.55 MB -47.57 KB (-0.54%)

cmyr
cmyr reviewed Jan 5, 2022
View reviewed changes
src/glyph/parse.rs Outdated Show resolved Hide resolved
@linebender linebender deleted a comment from github-actions bot Jan 5, 2022
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

🗜 Bloat check ⚖️

Comparing 150e79b against 61999a6

target old size new size difference
target/release/examples/load_save 1.9 MB 1.88 MB -18.6 KB (-0.96%)
target/debug/examples/load_save 8.6 MB 8.55 MB -47.35 KB (-0.54%)

cmyr
cmyr approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@cmyr cmyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay one more little note that you can take or leave, it applies to all these match statements; I find that sometimes using two matches with the conditional inline is clearer than having the conditional inside the match block?

src/glyph/parse.rs Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

🗜 Bloat check ⚖️

Comparing c9041d9 against 61999a6

target old size new size difference
target/release/examples/load_save 1.9 MB 1.88 MB -18.6 KB (-0.96%)
target/debug/examples/load_save 8.6 MB 8.55 MB -47.35 KB (-0.54%)

@madig madig merged commit e511ca2 into master Jan 5, 2022
@madig madig deleted the cut-down-builder branch January 5, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmyr cmyr cmyr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp GlyphBuilder
2 participants
@madig @cmyr