Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cut down builder #235

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Cut down builder #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cb8a887
Roll GlyphBuilder back into the parser
madig Jan 5, 2022
18b6b72
Remove redundant ErrorKind::UnexpectedTag
madig Jan 5, 2022
771da06
Add some tests
madig Jan 5, 2022
00b6f5b
Simplify duplicate check for image and note
madig Jan 5, 2022
d54e507
Expand match arms a bit
madig Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,9 +469,6 @@ pub enum ErrorKind {
/// Missing a close tag.
#[error("missing close tag")]
MissingCloseTag,
/// Has an unexpected tag.
#[error("unexpected tag")]
UnexpectedTag,
/// Has an invalid hexadecimal value.
#[error("bad hex value")]
BadHexValue,
Expand Down Expand Up @@ -556,6 +553,27 @@ pub enum ErrorKind {
/// Has an unexpected image field.
#[error("unexpected image field")]
UnexpectedImageField,
/// An element that can occur just once occured a second time.
#[error("there must be only one '{0}' element")]
DuplicateElement(&'static str),
/// An element that can occur just once occured a second time.
#[error("unexpected element in a format 1 glif: {0}")]
UnexpectedV1Element(&'static str),
/// An element that can occur just once occured a second time.
#[error("unexpected attribute in a format 1 glif: {0}")]
UnexpectedV1Attribute(&'static str),
/// A component had an empty `base` attribute.
#[error("a 'component' element has an empty 'base' attribute")]
ComponentEmptyBase,
/// A component was missing a `base` attribute.
#[error("a 'component' element is missing a 'base' attribute")]
ComponentMissingBase,
/// The glyph 'lib' element must contain a dictionary.
#[error("the glyph lib must be a dictionary")]
LibMustBeDictionary,
/// An angle was out of bounds.
#[error("an angle must be between 0 and 360°")]
BadAngle,
}

#[doc(hidden)]
Expand Down
Loading