Enable users to monitor the min.insync.replicas of all topics #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zornhsu
approved these changes
Jul 20, 2021
...l/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/ClusterPartitionState.java
Outdated
Show resolved
Hide resolved
...-control/src/main/java/com/linkedin/kafka/cruisecontrol/servlet/response/PartitionState.java
Outdated
Show resolved
Hide resolved
efeg
added a commit
to efeg/cruise-control
that referenced
this pull request
Jul 20, 2021
efeg
added a commit
to efeg/cruise-control
that referenced
this pull request
Jul 20, 2021
fvaleri
added a commit
to fvaleri/strimzi-kafka-operator
that referenced
this pull request
Dec 22, 2023
The cluster.configs.file configuration property is never used. The KafkaTopicConfigProvider is now deprecated, and KafkaAdminTopicConfigProvider is used by default. The KafkaAdminTopicConfigProvider retrieves cluster configs via the Kafka admin client rather than reading them from a file. linkedin/cruise-control#1622 Signed-off-by: Federico Valeri <[email protected]>
This was referenced Dec 22, 2023
Closed
fvaleri
added a commit
to fvaleri/strimzi-kafka-operator
that referenced
this pull request
Jan 3, 2024
The Cruise Control's cluster.configs.file configuration property is never used. The KafkaTopicConfigProvider is now deprecated in favor of KafkaAdminTopicConfigProvider, which is used by default. The KafkaAdminTopicConfigProvider retrieves cluster configs via the Kafka admin client rather than reading them from a file. For these reasons, we can get rid of this configuration and related code. linkedin/cruise-control#1622 Signed-off-by: Federico Valeri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #1621.
Enable users to monitor the
min.insync.replicasof all topics viakafka_cluster_stateendpoint.Update the default value of
topic.config.provider.classconfig to switch fromZK-based clienttoAdminClientby default (see earlier PR that introduced admin client-based topic config provider).Make
KafkaAdminTopicConfigProviderretrieve cluster configs via admin client rather than reading them from a file.Make private variables / methods of
KafkaTopicConfigProviderandKafkaAdminTopicConfigProviderto let them be extended.This patch has been tested on a Kafka cluster containing topics that (1) override the cluster default and (2) use the cluster default. The response has been verified for correctness of the corresponding value for each topic with and without
json=trueparameter. Excerpt (i.e. showing only selected partition states) from the example plaintext response withverbose=true: