Remove Cruise Control's cluster.configs.file and related code #9499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cruise Control's cluster.configs.file configuration property is never used. The KafkaTopicConfigProvider is now deprecated in favor of KafkaAdminTopicConfigProvider, which is used by default. The KafkaAdminTopicConfigProvider retrieves cluster configs via the Kafka admin client rather than reading them from a file. For these reasons, we can get rid of this configuration and related code. linkedin/cruise-control#1622 Signed-off-by: Federico Valeri <[email protected]>
scholzj
approved these changes
Jan 7, 2024
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tombentley
approved these changes
Jan 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cruise Control's cluster.configs.file configuration property is never used. The KafkaTopicConfigProvider is now deprecated in favor of KafkaAdminTopicConfigProvider, which is used by default. The KafkaAdminTopicConfigProvider retrieves cluster configs via the Kafka admin client rather than reading them from a file. For these reasons, we can get rid of this configuration and related code.
linkedin/cruise-control#1622