Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent versions of ppx_sexp_conv cause warnings in lens code #1179

Open
frank-emrich opened this issue Jun 20, 2023 · 0 comments
Open

Recent versions of ppx_sexp_conv cause warnings in lens code #1179

frank-emrich opened this issue Jun 20, 2023 · 0 comments

Comments

@frank-emrich
Copy link
Contributor

Compiling Links with the recent version v0.16.0 of ppx_sexp_conv causes many warnings such as the following (which are treated as errors for the purposes of CI)

File "lens/column.ml", lines 4-11, characters 0-23:
 4 | type t = {
 5 |   table : string;
 6 |   name : string;
 7 |   alias : string;
 8 |   typ : Type.t;
 9 |   present : bool;
10 | }
11 | [@@deriving show, sexp]
Error (warning 40 [name-out-of-scope]): Field was selected from type Sexplib0.Sexp_conv_record.Fields.t.

As a temporary workaround, #1178 requires using earlier versions of this library.

frank-emrich added a commit that referenced this issue Jun 23, 2023
Links currently has two database drivers for MySQL databases, provided by the packages links-mysql and links-mysql8. The former uses the opam package mysql, while the latter uses mysql8.

Unfortunately, the mysql opam package cannot be built on recent versions of Ubuntu anymore and has not been updated in a while. mysql8 is a fork of mysql that does work on more recent versions of Ubuntu, and supports MySQL version 8 (in addition to earlier versions).

Since mysql8 is backwards compatible with earlier versions of MySQL, its functionality subsumes that of mysql. However, since it's a fork of mysql we kept the links-mysql driver around in case the original mysql package gets updated eventually.

This PR is the result of giving up on this hope for the time being: It removes the links-mysql package and associated code within Links.

Since the CI is currently blocked by this, this PR also applies a temporary fix for #1179, by imposing a bound on the version of ppx_sexp_conv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant