-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove links-mysql database driver #1178
Remove links-mysql database driver #1178
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Following this patch we should do a minor release to bump the version of all links packages except for links-mysql
.
Yes, but let's wait with the release until #1179 is fixed. This PR hotfixes it, which involves a version constraint in |
Links currently has two database drivers for MySQL databases, provided by the packages
links-mysql
andlinks-mysql8
. The former uses the opam packagemysql
, while the latter usesmysql8
.Unfortunately, the
mysql
opam package cannot be built on recent versions of Ubuntu anymore and has not been updated in a while.mysql8
is a fork ofmysql
that does work on more recent versions of Ubuntu, and supports MySQL version 8 (in addition to earlier versions).Since
mysql8
is backwards compatible with earlier versions of MySQL, its functionality subsumes that ofmysql
. However, since it's a fork ofmysql
we kept thelinks-mysql
driver around in case the originalmysql
package gets updated eventually.This PR is the result of giving up on this hope for the time being: It removes the
links-mysql
package and associated code within Links.Since the CI is currently blocked by this, this PR also applies a temporary fix for #1179, by imposing a bound on the version of
ppx_sexp_conv