Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove links-mysql database driver #1178

Merged
merged 13 commits into from
Jun 23, 2023

Conversation

frank-emrich
Copy link
Contributor

@frank-emrich frank-emrich commented Jun 20, 2023

Links currently has two database drivers for MySQL databases, provided by the packages links-mysql and links-mysql8. The former uses the opam package mysql, while the latter uses mysql8.

Unfortunately, the mysql opam package cannot be built on recent versions of Ubuntu anymore and has not been updated in a while. mysql8 is a fork of mysql that does work on more recent versions of Ubuntu, and supports MySQL version 8 (in addition to earlier versions).

Since mysql8 is backwards compatible with earlier versions of MySQL, its functionality subsumes that of mysql. However, since it's a fork of mysql we kept the links-mysql driver around in case the original mysql package gets updated eventually.

This PR is the result of giving up on this hope for the time being: It removes the links-mysql package and associated code within Links.

Since the CI is currently blocked by this, this PR also applies a temporary fix for #1179, by imposing a bound on the version of ppx_sexp_conv

@frank-emrich frank-emrich changed the title Deprecate links-mysql database driver Remove links-mysql database driver Jun 20, 2023
@dhil dhil self-requested a review June 20, 2023 16:56
Copy link
Member

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. Following this patch we should do a minor release to bump the version of all links packages except for links-mysql.

@frank-emrich
Copy link
Contributor Author

Yes, but let's wait with the release until #1179 is fixed. This PR hotfixes it, which involves a version constraint in links.opam, which I'd like to avoid in the released package.

@frank-emrich frank-emrich merged commit 7eb0d58 into links-lang:master Jun 23, 2023
@frank-emrich frank-emrich deleted the deprecate-mysql-non-8 branch June 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants