Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integration tests #531

Closed
wants to merge 18 commits into from
Closed

integration tests #531

wants to merge 18 commits into from

Conversation

vshanthe
Copy link
Contributor

@vshanthe vshanthe commented Jun 20, 2024

📝 Description

Added Integration Test Account modules
What does this PR do and why is this change necessary?
Test coverage

✔️ How to Test

make testint

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe added the testing for updates to the testing suite in the changelog. label Jun 20, 2024
@vshanthe vshanthe requested a review from a team as a code owner June 20, 2024 15:12
@vshanthe vshanthe requested review from ykim-akamai and yec-akamai and removed request for a team June 20, 2024 15:12
@ykim-akamai
Copy link
Contributor

LGTM mostly, but I had some failures running on my personal test account in record fixture mode. I think it might be better to make these assertions more flexible

    account_settings_test.go:24: Expected Managed to be true, got false
--- FAIL: TestAccountSettings_Get (0.46s)
=== RUN   TestAccountSettings_Update
    account_settings_test.go:52: Error updating Account Settings, expected struct, got error [400] [longview_subscription] longview_subscription editing at this location is no longer available. Please use the /longview/plan endpoint instead.
--- FAIL: TestAccountSettings_Update (0.13s)
=== RUN   TestInvoice_Get
    account_invoice_test.go:28: Error getting Invoice, expected struct, got error [404] Not found
--- FAIL: TestInvoice_Get (0.19s)
=== RUN   TestInvoiceItems_List
    account_invoice_test.go:50: Error getting Invoice Items, expected struct, got error [404] Not found
--- FAIL: TestInvoiceItems_List (0.13s)

@vshanthe
Copy link
Contributor Author

vshanthe commented Jun 28, 2024

LGTM mostly, but I had some failures running on my personal test account in record fixture mode. I think it might be better to make these assertions more flexible

    account_settings_test.go:24: Expected Managed to be true, got false
--- FAIL: TestAccountSettings_Get (0.46s)
=== RUN   TestAccountSettings_Update
    account_settings_test.go:52: Error updating Account Settings, expected struct, got error [400] [longview_subscription] longview_subscription editing at this location is no longer available. Please use the /longview/plan endpoint instead.
--- FAIL: TestAccountSettings_Update (0.13s)
=== RUN   TestInvoice_Get
    account_invoice_test.go:28: Error getting Invoice, expected struct, got error [404] Not found
--- FAIL: TestInvoice_Get (0.19s)
=== RUN   TestInvoiceItems_List
    account_invoice_test.go:50: Error getting Invoice Items, expected struct, got error [404] Not found
--- FAIL: TestInvoiceItems_List (0.13s)

I have test on my personal account and GA account as well, passing both cases
=== RUN TestAccountSettings_Get
--- PASS: TestAccountSettings_Get (0.00s)
=== RUN TestAccountSettings_Update
--- PASS: TestAccountSettings_Update (0.00s)

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some failures:
--- FAIL: TestInvoice_Get (0.00s)
--- FAIL: TestInvoiceItems_List (0.00s)
--- FAIL: TestAccountSettings_Get (0.00s)
--- FAIL: TestAccountSettings_Update (0.00s)
--- FAIL: TestAccountTransfer_Get (0.00s)

@lgarber-akamai
Copy link
Contributor

Looks like you'll need a quick make tidy to fix the failing CI

Copy link
Contributor

@ykim-akamai ykim-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests pass locally. Nice work!

Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing on my end, great work!

@vshanthe
Copy link
Contributor Author

vshanthe commented Jul 26, 2024

closing this PR and raising the new PR due the base branch requires all commits to be signed resolving it creating too many conflicts
raised new PR - #561

@vshanthe vshanthe closed this Jul 26, 2024
@vshanthe vshanthe deleted the add_tests branch July 26, 2024 11:17
@vshanthe vshanthe mentioned this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants