Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test #561

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Integration test #561

merged 2 commits into from
Jul 29, 2024

Conversation

vshanthe
Copy link
Contributor

📝 Description

As a part of test coverage added integration test
What does this PR do and why is this change necessary?
Referring to - #531

✔️ How to Test

make testint

What are the steps to reproduce the issue or verify the changes?

How do I run the relevant unit/integration tests?

📷 Preview

If applicable, include a screenshot or code snippet of this change. Otherwise, please remove this section.

@vshanthe vshanthe requested a review from a team as a code owner July 26, 2024 11:32
@vshanthe vshanthe requested review from lgarber-akamai and yec-akamai and removed request for a team July 26, 2024 11:32
@vshanthe vshanthe added the testing for updates to the testing suite in the changelog. label Jul 26, 2024
@vshanthe vshanthe mentioned this pull request Jul 26, 2024
@vshanthe vshanthe requested a review from ykim-1 July 26, 2024 11:33
Copy link
Contributor

@lgarber-akamai lgarber-akamai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Carrying over my approval from #531, nice work!

Copy link
Contributor

@ykim-1 ykim-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vshanthe vshanthe merged commit 7e19dbb into linode:main Jul 29, 2024
4 checks passed
@vshanthe vshanthe deleted the add_integration branch July 29, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing for updates to the testing suite in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants