-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8083] - Linode Create v2 - Disk Encryption #10535
upcoming: [M3-8083] - Linode Create v2 - Disk Encryption #10535
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to test a bit more on Monday, but I noticed these (I believe they stem from the known issue you listed in the description):
- the Backups notice remains when you change the region (if you previously had "Encrypt Disk" checked)
- when you change the region from one that supports LDE to one that doesn't, the payload will still have
disk_encryption: "enabled"
- when you change the region from one that supports LDE to one that doesn't, "Encrypted" remains in the summary at the bottom of the page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good!
Not sure if my comments will be pertinent to this PR, the v1 flow or both, but i noticed a some potential improvements to make to the UI/UX
The tooltip mentions the feature not being available in the selected region, but I have not selected a region yet.
the way we treat the lack of selected region and unavailability is quite inconsistent with the way it was just done for placement groups. I wonder if it'd be a good time to reel the UX team and confirm the overall messaging. @dwiley-akamai any thoughts?
I agree with all of that and noticed the same things @abailly-akamai. I was thinking: Once we get Linode Create v2 "done", we can sync up with UX to establish consistency on those items and implement it in the new create flow. |
I'd also be in favor of having UX review things comprehensively once the v2 Create flow is done. There are additional inconsistencies across the sections when an unsupported region is selected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dwiley-akamai I merged develop in. Scroll into view should work now. |
Sounds good - we should make sure to remember to update both flows when UX changes happen. thanks folks! |
I think the goal would to be only update v2 and launch it with the new UX or after the fact @abailly-akamai |
Description 📝
Preview 📷
How to test 🧪
Prerequisites
Linode Create v2
feature flag on 🏴Verification steps
linode_disk_encryption
tag on your account and the flag is enabledKnown issues
As an Author I have considered 🤔