-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upcoming: [M3-8145] – Update LDE copy in Linode Create flow when Distributed region is selected #10576
upcoming: [M3-8145] – Update LDE copy in Linode Create flow when Distributed region is selected #10576
Conversation
Coverage Report: ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dwiley-akamai - I confirmed:
- Selecting a distributed region disables the checkbox with a help tooltip specific to distributed regions and the helper text described in the testing steps.
- Selecting Newark (encryption available) still enables the checkbox by default.
- For all other selected regions (or no selected region), the helper text contains the Learn more link, which links to a real page.
- Changes are feature flagged.
Minor thing that is a little odd: when no region is selected, the help tooltip says "Disk encryption is not available in the selected region", when a user might find it more helpful if it said something more like "Select a region to enable disk encryption".
The plan is to address that and other small oddities/inconsistencies in the flow once Linode Create v2 is rolled out: #10535 (comment) |
Ah, thanks, missed that comment thread! Sorry to be repetitive - I'm glad we're all thinking similarly. |
e2e failures look to be unrelated tho another run wouldn't hurt |
…and streamline logic governing Disk Encryption description copy and disabled reasons
…ributed region is selected (linode#10576)
Description 📝
Update LDE copy in Linode Create flow when Distributed region is selected
Changes 🔄
DISK_ENCRYPTION_GENERAL_DESCRIPTION
Target release date 🗓️
6/24
How to test 🧪
Prerequisites
Verification steps
Without the tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI. Otherwise,
As an Author I have considered 🤔