Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upcoming: [M3-8145] – Update LDE copy in Linode Create flow when Distributed region is selected #10576

Conversation

dwiley-akamai
Copy link
Contributor

Description 📝

Update LDE copy in Linode Create flow when Distributed region is selected

Changes 🔄

  • Copy changes for Linode Create and Linode Create v2
  • Docs link added in DISK_ENCRYPTION_GENERAL_DESCRIPTION

Target release date 🗓️

6/24

How to test 🧪

Prerequisites

  1. Have the linode_disk_encryption tag on your account
  2. Point at the alpha/dev environment
  3. Have the Linode Disk Encryption (LDE) flag in our dev tool toggled on

Verification steps

Without the tag and/or with the LDE flag in our dev tool toggled off, you should not see any LDE-related things in the UI. Otherwise,

  1. The "Encrypt Disk" checkbox should be disabled if you selected a Distributed region
  • Disk Encryption help text should read: “Distributed Compute Instances are secured using disk encryption. Encryption and decryption are automatically managed for you.”
  • Tooltip should read: "Distributed instances are encrypted by default and the setting cannot be changed."
  1. For other regions, the description help text should have a "Learn more" that points at a reserved doc URL

As an Author I have considered 🤔

  • 👀 Doing a self review
  • ❔ Our contribution guidelines
  • 🤏 Splitting feature into small PRs
  • ➕ Adding a changeset
  • 🧪 Providing/Improving test coverage
  • 🔐 Removing all sensitive information from the code and PR description
  • 🚩 Using a feature flag to protect the release
  • 👣 Providing comprehensive reproduction steps
  • 📑 Providing or updating our documentation
  • 🕛 Scheduling a pair reviewing session
  • 📱 Providing mobile support
  • ♿ Providing accessibility support

@dwiley-akamai dwiley-akamai added the Linode Disk Encryption (LDE) Relating to LDE project label Jun 12, 2024
@dwiley-akamai dwiley-akamai self-assigned this Jun 12, 2024
@dwiley-akamai dwiley-akamai requested a review from a team as a code owner June 12, 2024 21:18
@dwiley-akamai dwiley-akamai requested review from mjac0bs and abailly-akamai and removed request for a team June 12, 2024 21:18
Copy link

github-actions bot commented Jun 12, 2024

Coverage Report:
Base Coverage: 82.84%
Current Coverage: 82.85%

Copy link
Contributor

@mjac0bs mjac0bs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dwiley-akamai - I confirmed:

  • Selecting a distributed region disables the checkbox with a help tooltip specific to distributed regions and the helper text described in the testing steps.
  • Selecting Newark (encryption available) still enables the checkbox by default.
  • For all other selected regions (or no selected region), the helper text contains the Learn more link, which links to a real page.
  • Changes are feature flagged.

Minor thing that is a little odd: when no region is selected, the help tooltip says "Disk encryption is not available in the selected region", when a user might find it more helpful if it said something more like "Select a region to enable disk encryption".

@mjac0bs mjac0bs added the Add'tl Approval Needed Waiting on another approval! label Jun 13, 2024
@dwiley-akamai
Copy link
Contributor Author

Minor thing that is a little odd: when no region is selected, the help tooltip says "Disk encryption is not available in the selected region", when a user might find it more helpful if it said something more like "Select a region to enable disk encryption".

The plan is to address that and other small oddities/inconsistencies in the flow once Linode Create v2 is rolled out: #10535 (comment)

@mjac0bs
Copy link
Contributor

mjac0bs commented Jun 13, 2024

Minor thing that is a little odd: when no region is selected, the help tooltip says "Disk encryption is not available in the selected region", when a user might find it more helpful if it said something more like "Select a region to enable disk encryption".

The plan is to address that and other small oddities/inconsistencies in the flow once Linode Create v2 is rolled out: #10535 (comment)

Ah, thanks, missed that comment thread! Sorry to be repetitive - I'm glad we're all thinking similarly.

@abailly-akamai
Copy link
Contributor

e2e failures look to be unrelated tho another run wouldn't hurt

@bnussman-akamai bnussman-akamai added Approved Multiple approvals and ready to merge! and removed Add'tl Approval Needed Waiting on another approval! labels Jun 14, 2024
…and streamline logic governing Disk Encryption description copy and disabled reasons
@dwiley-akamai dwiley-akamai merged commit a5f18c7 into linode:develop Jun 14, 2024
18 checks passed
@dwiley-akamai dwiley-akamai deleted the M3-8145-linode-create-lde-distributed-region branch June 14, 2024 18:37
nikhagra-akamai pushed a commit to nikhagra-akamai/manager that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Multiple approvals and ready to merge! Linode Disk Encryption (LDE) Relating to LDE project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants