Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass segment duration to transcoder instead of overall duration #105

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

thomshutt
Copy link
Contributor

Resolves #99

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #105 (4230c07) into main (2724d38) will increase coverage by 0.23892%.
The diff coverage is 80.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #105         +/-   ##
===================================================
+ Coverage   38.79817%   39.03709%   +0.23892%     
===================================================
  Files             24          24                 
  Lines           1531        1537          +6     
===================================================
+ Hits             594         600          +6     
  Misses           859         859                 
  Partials          78          78                 
Impacted Files Coverage Δ
handlers/misttriggers/recording_end.go 18.88112% <0.00000%> (ø)
handlers/transcode.go 40.74074% <0.00000%> (ø)
transcode/transcode.go 43.33333% <75.00000%> (ø)
transcode/manifest.go 73.91304% <100.00000%> (+1.82002%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2724d38...4230c07. Read the comment docs.

Impacted Files Coverage Δ
handlers/misttriggers/recording_end.go 18.88112% <0.00000%> (ø)
handlers/transcode.go 40.74074% <0.00000%> (ø)
transcode/transcode.go 43.33333% <75.00000%> (ø)
transcode/manifest.go 73.91304% <100.00000%> (+1.82002%) ⬆️

Copy link
Contributor

@AlexKordic AlexKordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done!

@thomshutt thomshutt merged commit af165cb into main Oct 31, 2022
@thomshutt thomshutt deleted the use-correct-duration branch October 31, 2022 10:53
iameli pushed a commit that referenced this pull request Feb 7, 2023
Files changed:\nM	manifest.yaml

Co-authored-by: livepeer-docker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcode of BBB fails with "Invalid Duration"
2 participants