Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transcode upload renditions using remote B #107

Closed

Conversation

emranemran
Copy link
Collaborator

@emranemran emranemran commented Oct 31, 2022

/Fix #99

@emranemran emranemran requested review from thomshutt and AlexKordic and removed request for thomshutt October 31, 2022 04:30
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #107 (cda5b37) into main (75c5175) will decrease coverage by 0.03969%.
The diff coverage is 44.44444%.

❗ Current head cda5b37 differs from pull request most recent head 5abe470. Consider uploading reports for the commit 5abe470 to get more accurate results

Impacted file tree graph

@@                 Coverage Diff                 @@
##                main        #107         +/-   ##
===================================================
- Coverage   39.03709%   38.99740%   -0.03969%     
===================================================
  Files             24          24                 
  Lines           1537        1536          -1     
===================================================
- Hits             600         599          -1     
  Misses           859         859                 
  Partials          78          78                 
Impacted Files Coverage Δ
clients/broadcaster.go 0.00000% <0.00000%> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
clients/broadcaster_remote.go 0.00000% <0.00000%> (ø)
handlers/misttriggers/recording_end.go 18.88112% <0.00000%> (ø)
handlers/transcode.go 40.74074% <0.00000%> (ø)
transcode/manifest.go 72.09302% <ø> (-1.82002%) ⬇️
transcode/transcode.go 46.31579% <57.14286%> (+2.98246%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c5175...5abe470. Read the comment docs.

Impacted Files Coverage Δ
clients/broadcaster.go 0.00000% <0.00000%> (ø)
clients/broadcaster_local.go 0.00000% <0.00000%> (ø)
clients/broadcaster_remote.go 0.00000% <0.00000%> (ø)
handlers/misttriggers/recording_end.go 18.88112% <0.00000%> (ø)
handlers/transcode.go 40.74074% <0.00000%> (ø)
transcode/manifest.go 72.09302% <ø> (-1.82002%) ⬇️
transcode/transcode.go 46.31579% <57.14286%> (+2.98246%) ⬆️

@emranemran emranemran changed the title transcode: update logic for uploading renditions to handle remote Bro… transcode: fix segment duration bug + upload renditions using remote B Oct 31, 2022
@emranemran emranemran force-pushed the emran/upload-rendition-for-remote-transcode-jobs branch 2 times, most recently from 1852f17 to cda5b37 Compare October 31, 2022 05:56
@thomshutt
Copy link
Contributor

Duration thing is fixed in #105

Let's hold off on using remote Bs for now and see if we can fix the local one today

@emranemran emranemran force-pushed the emran/upload-rendition-for-remote-transcode-jobs branch from cda5b37 to 5abe470 Compare October 31, 2022 14:39
@emranemran emranemran changed the title transcode: fix segment duration bug + upload renditions using remote B transcode upload renditions using remote B Oct 31, 2022
@emranemran emranemran force-pushed the emran/upload-rendition-for-remote-transcode-jobs branch from 5abe470 to 7b07be3 Compare October 31, 2022 14:57
@AlexKordic
Copy link
Contributor

Looks like duplicate #112 :)

@thomshutt thomshutt closed this Nov 24, 2022
@hjpotter92 hjpotter92 deleted the emran/upload-rendition-for-remote-transcode-jobs branch May 30, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcode of BBB fails with "Invalid Duration"
3 participants