Ignore parametric stereo probing error on output files #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjh1
requested review from
thomshutt and
emranemran
and removed request for
thomshutt and
emranemran
Codecov Report
@@ Coverage Diff @@
## main #529 +/- ##
===================================================
+ Coverage 52.84598% 54.07510% +1.22912%
===================================================
Files 45 45
Lines 3584 3595 +11
===================================================
+ Hits 1894 1944 +50
+ Misses 1538 1492 -46
- Partials 152 159 +7
Continue to review full report in Codecov by Sentry.
|
mjh1
force-pushed
the
mh/probe-output-file
branch
from
14a74f5
to
1a7fb87
Compare
mjh1
changed the title
thomshutt
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing frequent errors probing the output mp4s for the mist pipeline, these files were still playable and the fields we need from the probe are still present so we should be able to safely ignore this probe error.