Ignore parametric stereo probing error on output files

pipeline/coordinator_test.go

@@ -634,7 +634,7 @@ type stubFFprobe struct {
 	Err      error
 }
 
-func (f stubFFprobe) ProbeFile(_ string) (video.InputVideo, error) {
+func (f stubFFprobe) ProbeFile(_ string, _ ...string) (video.InputVideo, error) {
 	if f.Err != nil {
 		return video.InputVideo{}, f.Err
 	}

video/probe.go

@@ -13,17 +13,20 @@ import (
 )
 
 type Prober interface {
-	ProbeFile(url string) (InputVideo, error)
+	ProbeFile(url string, ffProbeOptions ...string) (InputVideo, error)
 }
 
 type Probe struct{}
 
-func (p Probe) ProbeFile(url string) (iv InputVideo, err error) {
+func (p Probe) ProbeFile(url string, ffProbeOptions ...string) (iv InputVideo, err error) {
+	if len(ffProbeOptions) == 0 {
+		ffProbeOptions = []string{"-loglevel", "error"}
+	}
 	var data *ffprobe.ProbeData
 	operation := func() error {
 		probeCtx, probeCancel := context.WithTimeout(context.Background(), 60*time.Second)
 		defer probeCancel()
-		data, err = ffprobe.ProbeURL(probeCtx, url, "-loglevel", "error")
+		data, err = ffprobe.ProbeURL(probeCtx, url, ffProbeOptions...)
 		return err
 	}
 

video/profiles.go

@@ -3,6 +3,7 @@ package video
 import (
 	"fmt"
 	"strconv"
+	"strings"
 )
 
 const (
@@ -167,10 +168,9 @@ type OutputVideoFile struct {
 }
 
 func PopulateOutput(probe Prober, outputURL string, videoFile OutputVideoFile) (OutputVideoFile, error) {
-	outputVideoProbe, err := probe.ProbeFile(outputURL)
+	outputVideoProbe, err := runProbe(probe, outputURL)
 	if err != nil {
 		return OutputVideoFile{}, fmt.Errorf("error probing output file from S3: %w", err)
-
 	}
 	videoFile.SizeBytes = outputVideoProbe.SizeBytes
 	videoTrack, err := outputVideoProbe.GetTrack(TrackTypeVideo)
@@ -182,3 +182,16 @@ func PopulateOutput(probe Prober, outputURL string, videoFile OutputVideoFile) (
 	videoFile.Bitrate = videoTrack.Bitrate
 	return videoFile, nil
 }
+
+func runProbe(probe Prober, outputURL string) (InputVideo, error) {
+	outputVideoProbe, err := probe.ProbeFile(outputURL)
+	if err == nil {
+		return outputVideoProbe, nil
+	}
+
+	// ignore this probing error if found and re-run with fatal loglevel to obtain the probe data
+	if strings.Contains(strings.ToLower(err.Error()), "parametric stereo signaled to be not-present but was found in the bitstream") {
+		return probe.ProbeFile(outputURL, "-loglevel", "fatal")
+	}
+	return InputVideo{}, err
+}

video/profiles_test.go

@@ -130,3 +130,14 @@ func TestGetPlaybackProfiles(t *testing.T) {
 		})
 	}
 }
+
+func TestPopulateOutput(t *testing.T) {
+	out, err := PopulateOutput(Probe{}, "fixtures/parametric-stereo-error.mp4", OutputVideoFile{})
+	require.NoError(t, err)
+	require.Equal(t, OutputVideoFile{
+		SizeBytes: 275075,
+		Width:     576,
+		Height:    1024,
+		Bitrate:   315733,
+	}, out)
+}