Fix describeMismatchSafely in ScalarHasValue #14
Conversation
|
Job #14 is now in scope, role is |
| @@ -40,6 +40,11 @@ | |||
| * @author Yegor Bugayenko ([email protected]) | |||
| * @version $Id$ | |||
| * @since 0.11 | |||
| * @todo #7:30min Tests for all matchers should be added and in particular | |||
There was a problem hiding this comment.
@victornoel tests for all matchers is being handled starting in #1
There was a problem hiding this comment.
@llorllale yes, I noticed that the other day, but then I thought about leaving this todo because it concerns mainly describeMismatchSafely in the end.
I propose to reformulate it without the "tests for all matchers should be added", what do you think?
There was a problem hiding this comment.
@victornoel yes, please just leave out the part about "tests for all matchers should be added". The rest of the puzzle is fine
victornoel
force-pushed
the
7-sclarahasvalue-describe
branch
from
6017d48
to
7fe4f6f
Compare
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
+ Coverage 77.55% 81.55% +4%
- Complexity 27 29 +2
=========================================
Files 7 7
Lines 98 103 +5
Branches 1 1
=========================================
+ Hits 76 84 +8
+ Misses 22 19 -3
Continue to review full report at Codecov.
|
|
@llorllale I've rebased the branch on master since #15 was merged and I fixed the |
victornoel
force-pushed
the
7-sclarahasvalue-describe
branch
from
7fe4f6f
to
4ae45cd
Compare
victornoel
force-pushed
the
7-sclarahasvalue-describe
branch
from
4ae45cd
to
d3cd1e5
Compare
|
@llorllale everything is good now, thanks for waiting |
|
@rultor merge |
@llorllale OK, I'll try to merge now. You can check the progress of the merge here |
@llorllale Done! FYI, the full log is here (took me 5min) |
|
The job #14 is now out of scope |
#7
This add tests for
ScalarHasValueand implements properlydescribeMismatchSafely.Note that I had to ignore a checkstyle error so that the
ScalarHasValueclass does not expose internal methods to the outside, see yegor256/qulice#901 for a rationale.Also add a
@todofor doing the same work on other matchers.