Matcher ScalarHasValue has to override describeMismatchSafely for better output

[proshin-roman]

This ticket is moved from yegor256/cactoos#816

Currently, ScalarHasValue doesn't override method describeMismatchSafely that leads to the next problem:

final ScalarHasValue<String> matcher =
    new ScalarHasValue<>(new IsEqual<>("expected"));
final Scalar<String> scalar = new UncheckedScalar<>(() -> "actual");
final StringDescription description = new StringDescription();
matcher.describeMismatch(scalar, description);
System.out.println(description.toString());
// the out is:
// was <org.cactoos.scalar.UncheckedScalar@368239c8>
// how it should look like:
// was "actual"

so it prints an actual version incorrectly: default toString method is called for the Scalar.

Expected:

• the value of scalar is printed as an actual value of matching.

What should be fixed

• class ScalarHasValue has to override method describeMismatchSafely and convert Scalar to String properly.

[0crat]

@llorllale/z please, pay attention to this issue

[llorllale]

@0crat in

[0crat]

@0crat in (here)

@llorllale Job #7 is now in scope, role is DEV

[0crat]

Bug was reported, see §29: +15 point(s) just awarded to @proshin-roman/z

[0crat]

The job #7 assigned to @victornoel/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this

[victornoel]

@llorllale should other matchers be improved as well?

[llorllale]

@victornoel sure. You can also leave puzzles for continuing work past budget

[victornoel]

@0crat waiting for #14

[0crat]

@0crat waiting for #14 (here)

@victornoel The impediment for #7 was registered successfully by @victornoel/z

[0pdd]

@proshin-roman the puzzle #20 is still not solved.

[victornoel]

@proshin-roman the MR #14 has been merged, this issue can now be closed :)

[0crat]

@elenavolokhova/z please review this job completed by @victornoel/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[0crat]

The job #7 is now out of scope

[elenavolokhova]

@0crat quality good

[0crat]

Order was finished, quality is "good": +35 point(s) just awarded to @victornoel/z

[0crat]

Quality review completed: +8 point(s) just awarded to @elenavolokhova/z

[0pdd]

@proshin-roman the only puzzle #20 is solved here.

[0pdd]

@proshin-roman the puzzle #20 is still not solved.

[0pdd]

@proshin-roman the puzzle #230 is still not solved; solved: #20.