-
Notifications
You must be signed in to change notification settings - Fork 11.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Different formatting around type annotations with JS #107401
Comments
@llvm/issue-subscribers-clang-format Author: kadir çetinkaya (kadircet)
a.js:
```
ctrl.onCopy(/** @type {!WizEvent}*/ (
{event, targetElement: {el: () => selectedElement}}));
```
formatting after this change with
I can't really say this change looks like intended from the bug fix and code changes. Moreover, these kind of type annotations seems to be pretty common so unless the change deliberately changing behavior here can we restore the old behavior ? |
cc @owenca @gedare @HazardyKnusperkeks #93140 seems to be the change introducing this behavior |
It looks like unintended, and I have no object to restoring the old behavior. |
a.js:
formatting after this change with
clang-format -style='{AlignAfterOpenBracket: AlwaysBreak}' a.js
I can't really say this change looks like intended from the bug fix and code changes. Moreover, these kind of type annotations seems to be pretty common so unless the change deliberately changing behavior here can we restore the old behavior ?
The text was updated successfully, but these errors were encountered: