Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different spacing for nested function calls #107574

Closed
kadircet opened this issue Sep 6, 2024 · 2 comments · Fixed by #107506
Closed

Different spacing for nested function calls #107574

kadircet opened this issue Sep 6, 2024 · 2 comments · Fixed by #107506
Assignees
@owenca
Labels
clang-format regression

Comments

@kadircet
Copy link
Member

kadircet commented Sep 6, 2024 •
edited
Loading

Actual formatting:

$ ../llvm/build/bin/clang-format-bad -style='{AlignAfterOpenBracket: AlwaysBreak}' a.js
failedUserIds.push(
    ...subscriptioxxxxxxxxxxxxnSubset.map(
        subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(
    !subscriptioxxxxxxxxxxxxnSubset.map(
        subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(
    await subscriptioxxxxxxxxxxxxnSubset.map(
        subscxxxxxxxxxxxxription => subscription.getUserId()));

Expected formatting:

failedUserIds.push(...subscriptioxxxxxxxxxxxxnSubset.map(
    subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(!subscriptioxxxxxxxxxxxxnSubset.map(
    subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(await subscriptioxxxxxxxxxxxxnSubset.map(
    subscxxxxxxxxxxxxription => subscription.getUserId()));
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 6, 2024

@llvm/issue-subscribers-clang-format

Author: kadir çetinkaya (kadircet)

Actual formatting: ``` $ ../llvm/build/bin/clang-format-bad -style='{AlignAfterOpenBracket: AlwaysBreak}' a.js failedUserIds.push( ...subscriptioxxxxxxxxxxxxnSubset.map( subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(
!subscriptioxxxxxxxxxxxxnSubset.map(
subscxxxxxxxxxxxxription => subscription.getUserId()));


Expected formatting:

failedUserIds.push(...subscriptioxxxxxxxxxxxxnSubset.map(
subscxxxxxxxxxxxxription => subscription.getUserId()));

failedUserIds.push(!subscriptioxxxxxxxxxxxxnSubset.map(
subscxxxxxxxxxxxxription => subscription.getUserId()));

</details>

@kadircet
Copy link
Member Author

kadircet commented Sep 6, 2024

culprit seems to be ccae7b4

cc @gedare @owenca

@kadircet kadircet removed the regression:19 Regression in 19 release label Sep 6, 2024
@kadircet kadircet mentioned this issue Sep 6, 2024
Merged
@owenca owenca self-assigned this Sep 8, 2024
owenca added a commit to owenca/llvm-project that referenced this issue Sep 8, 2024
@owenca
Also fix llvm#107574.
4ff558c
@owenca owenca closed this as completed in 8168088 Sep 12, 2024
VitaNuo pushed a commit to VitaNuo/llvm-project that referenced this issue Sep 12, 2024
@owenca @VitaNuo
[clang-format] Fix regressions in BAS_AlwaysBreak (llvm#107506)
5aef8dd 
Fixes llvm#107401.
Fixes llvm#107574.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@owenca owenca

Labels
clang-format regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[clang-format] Fix regressions in BAS_AlwaysBreak owenca/llvm-project
3 participants
@kadircet @owenca @llvmbot