Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flask version #1394

Closed
cyberw opened this issue May 25, 2020 · 2 comments
Closed

Update flask version #1394

cyberw opened this issue May 25, 2020 · 2 comments
Labels

Comments

@cyberw
Copy link
Collaborator

cyberw commented May 25, 2020

Our minimum required flask version is too old (saw at least one person having an issue https://stackoverflow.com/questions/61969924/typeerror-when-i-run-a-locustfile-py)

https://flask.palletsprojects.com/en/1.1.x/changelog/#version-0-12-5 is a minimum, but we should probably go to 1.x right away.

I can do the PR

@cyberw cyberw added the bug label May 25, 2020
@cyberw
Copy link
Collaborator Author

cyberw commented May 25, 2020

Actually, the underlying issue is probably with Werkzeug. But 1.1.0 of Flask pins the version to a reasonably recent version of W, so I think that should be the most appropriate solution (rather than specifying an explicit version of W)

@heyman
Copy link
Member

heyman commented May 25, 2020

Sounds like a good idea!

@heyman heyman closed this as completed in 588c7a2 May 25, 2020
heyman added a commit that referenced this issue May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants