Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flask requirement. Fixes #1394 #1395

Merged
merged 1 commit into from
May 25, 2020
Merged

Conversation

cyberw
Copy link
Collaborator

@cyberw cyberw commented May 25, 2020

No description provided.

@cyberw
Copy link
Collaborator Author

cyberw commented May 25, 2020

Once this is merged, I'd like to make a new locust release (primarily because I think the previous one is borked on windows)

@cyberw cyberw requested a review from heyman May 25, 2020 14:55
@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #1395 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1395      +/-   ##
==========================================
- Coverage   81.15%   81.07%   -0.09%     
==========================================
  Files          26       26              
  Lines        2335     2335              
  Branches      361      361              
==========================================
- Hits         1895     1893       -2     
- Misses        348      349       +1     
- Partials       92       93       +1     
Impacted Files Coverage Δ
locust/user/task.py 96.17% <0.00%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a207489...588c7a2. Read the comment docs.

@heyman
Copy link
Member

heyman commented May 25, 2020

Looks good!

Once this is merged, I'd like to make a new locust release (primarily because I think the previous one is borked on windows)

Sounds like a good idea! 1.0.2 I guess?

@heyman heyman merged commit 2281589 into master May 25, 2020
@heyman
Copy link
Member

heyman commented May 25, 2020

I'll make the new release!

@heyman heyman deleted the bump-flask-version-dependency branch May 25, 2020 15:30
@cyberw
Copy link
Collaborator Author

cyberw commented May 25, 2020

Github still lists 0.14.6 as the latest release :-/

@cyberw
Copy link
Collaborator Author

cyberw commented May 25, 2020

I guess it has its own idea of releases, completely separate from git tags?

@heyman
Copy link
Member

heyman commented May 25, 2020

Oh, yeah.. Will fix a release for the latest version.

@heyman
Copy link
Member

heyman commented May 25, 2020

Done! They are tied to tags, but you have to create them manually (though I guess it might be possible to automate it somehow).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants