-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failure per seconds as a series in the chart #1140
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1140 +/- ##
==========================================
+ Coverage 75.46% 75.55% +0.09%
==========================================
Files 18 18
Lines 1818 1833 +15
Branches 276 279 +3
==========================================
+ Hits 1372 1385 +13
- Misses 382 384 +2
Partials 64 64
Continue to review full report at Codecov.
|
Thanks for the PR! I'm not sure that I like the |
locust/stats.py
Outdated
total_reqs = 0 | ||
total_failures = 0 | ||
for key in sorted(six.iterkeys(stats)): | ||
r = stats[key] | ||
total_rps += r.current_rps | ||
total_fps += r.current_fps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This variable doesn't seem to be used, so it should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to include it in the print_stats table. I'll do that instead.
I changed the UI to show 'Failures/s' as you suggested. Regarding changing Sometimes I like using an acronym that makes my code easier to read and nicer to the eyes. But it's a matter of taste I guess. |
Hmm, I'm not aware of any existing use of the I'm not against acronyms per se, but I don't really associate FPS with "failures per second", as opposed to RPS which I think is more commonly used for "requests per second" (even though I think one could make the argument that "requests/s" would be better as well). |
I meant the new variables and methods introduced as part of this PR. It's not just the I have no problem in renaming all variables/methods, just wanted to confirm. |
Ah, ok, got you! The reason I mentioned the JSON-blob was because even if not intended, it'll become part of a somewhat semi-public API, since it's not uncommon for people to request the stats endpoint "manually". Though, I do think it's better to avoid fps in variable names in the other code as well (though I think it's perfectly fine in CSS classes). |
@heyman done. |
Great! Thanks! |
While using locust it's very useful to know the % of requests failing. However when pushing heavy loads against a GCP service it's common the auto-scaling can't cope with demand. Having the failures being represented in the chart as a series is very valuable to understand how the scaling overall is working.