Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failures per second as a series in the chart #588

Closed
wants to merge 2 commits into from

Conversation

alercunha
Copy link
Contributor

As a user of locust it's very useful to know how many requests are failing in the chart. The failure % is useful but when pushing heavy loads against an API in my case it's common the autoscaling can't cope up with the demand and a lot of fails start to happen. Having those represented in the chart is very valuable to understand how the scaling overall is working.

image

@jrouaix
Copy link

jrouaix commented Jun 27, 2019

Too sad this PR is not merged since 2 years :'(

@alercunha
Copy link
Contributor Author

Too sad this PR is not merged since 2 years :'(

My default installation of locust still points to this branch. I find it much more useful that way....

@cyberw
Copy link
Collaborator

cyberw commented Oct 28, 2019

@heyman I think this is a very useful contribution (although I dont use the web ui myself). Ok to merge, if someone fixes the conflicts?

@cyberw
Copy link
Collaborator

cyberw commented Oct 28, 2019

Would be nice if we could make the line in the graph red instead of grey

@alercunha
Copy link
Contributor Author

@cyberw PR is too old. I'll drop this one and create a new PR fresh from master in a couple days.

@cyberw
Copy link
Collaborator

cyberw commented Oct 28, 2019

@alercunha Awesome!

@cyberw cyberw closed this Oct 28, 2019
@heyman
Copy link
Member

heyman commented Oct 28, 2019

I'm +1. I wonder if it's best to have the failure line in the same graph, or if it's better to have a separate graph for failures (as suggested in #952)? I also think that the color of the line should be red.

@cyberw
Copy link
Collaborator

cyberw commented Nov 7, 2019

@alercunha Is your new PR on the way? :)

@alercunha
Copy link
Contributor Author

@cyberw sorry I've been quite busy in the past few days. I'll try to get this done during the weekend.

@alercunha
Copy link
Contributor Author

@cyberw @heyman I posted a new PR. @heyman based on my experience having the failure line in the same graph makes more sense. Being able to see the correlation between the two lines in the same chart helped me figuring out the root cause of degradation of my service some years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants