Try to increase open files limit and warn if it is still too low afterwards #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: the warning is the most important thing, trying to set it (which may only work on MacOS) is more of a convenience |
Codecov Report
@@ Coverage Diff @@
## master #1375 +/- ##
==========================================
- Coverage 81.48% 81.32% -0.17%
==========================================
Files 26 26
Lines 2323 2329 +6
Branches 360 361 +1
==========================================
+ Hits 1893 1894 +1
- Misses 340 345 +5
Partials 90 90
Continue to review full report at Codecov.
|
…imum open files they allow a process to set, so reduce the target to what all allow
cgoldberg
reviewed
May 23, 2020
| # Increasing the limit to 10000 within a running process should work on at least MacOS. | ||
| # It does not work on all OS:es, but we should be no worse off for trying. | ||
| resource.setrlimit(resource.RLIMIT_NOFILE, [10000, resource.RLIM_INFINITY]) | ||
| except: |
There was a problem hiding this comment.
bare except also catches KeyboardInterrupt and SystemExit.... change this to except Exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1368