Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to increase open files limit and warn if it is still too low afterwards #1375

Merged
merged 3 commits into from
May 22, 2020
Merged

Try to increase open files limit and warn if it is still too low afterwards #1375

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81c0222
Try to increase open files limit and warn if it is still too low afte…
cyberw May 15, 2020
b1c2e9c
Different MacOS machines (both running Mojave) have differ in the max…
cyberw May 18, 2020
49ce465
Add comment about when setting open file count may be expected to work
cyberw May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions locust/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
import socket
import sys
import time
import resource

import gevent

Expand Down Expand Up @@ -153,6 +154,14 @@ def main():
# list() call is needed to consume the dict_view object in Python 3
user_classes = list(user_classes.values())

try:
if resource.getrlimit(resource.RLIMIT_NOFILE)[0] < 10000:
# Increasing the limit to 10000 within a running process should work on at least MacOS.
# It does not work on all OS:es, but we should be no worse off for trying.
resource.setrlimit(resource.RLIMIT_NOFILE, [10000, resource.RLIM_INFINITY])
except:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bare except also catches KeyboardInterrupt and SystemExit.... change this to except Exception

logger.warning("System open file limit setting is not high enough for load testing, and the OS wouldnt allow locust to increase it by itself. See https://docs.locust.io/en/stable/installation.html#increasing-maximum-number-of-open-files-limit for more info.")

# create locust Environment
environment = create_environment(user_classes, options, events=locust.events)

Expand Down