When new required fields with a default value are added autoupdate shouldn't fail

[faridnsh]

Steps to produce:

1 - Create a model and run autoupdate/automigrate
2 - Add a new required property with a default value to the model for example:

    "newProperty": {
      "type": "Number",
      "required": true,
      "default": 0
    }

3 - Run autoupdate again

What's expected: New column should be added with the default value.

What actually happens: Autoupdate fails here and throws this:

error: column "newProperty" contains null values

It happens because it tries to add column with NOT NULL constraint, but this is only possible, if we give a default value, but loopback-connector-postgresql ignores the given default value in the model configuration.

I would like to contribute this myself, but I'm not sure if I'm getting the test configuration to work. I'm getting error: password authentication failed for user "user" for the first test, but the credentials in the configuration are correct and also a lot of other tests are failing.

[Elindorath]

@raymondfeng @superkhau @bajtos : I would like to address this issue, but I'm unable to run the test right now. I saw on the Readme that I need to contact you for instructions so I do.

[raymondfeng]

@Elindorath You have two ways to configure your postgres connection.

1. Set up env vars (https://github.com/strongloop/loopback-connector-postgresql/blob/master/test/init.js#L10)

export CI=true
export TEST_POSTGRESQL_HOST=localhost
export TEST_POSTGRESQL_PORT=5432
export TEST_POSTGRESQL_USER=myUser
export TEST_POSTGRESQL_PASSWORD=myPassword

Or drop .loopbackrc file into your home dir:

{
    "test": {
        "postgresql": {
            "host": "localhost",
            "port": 5432,
            "database": "test",
            "username": "test",
            "password": "testpass"
        }
    }
}

Please also use https://github.com/strongloop/loopback-connector-postgresql/blob/master/test/tables.sql to populate your test db.

[Elindorath]

Thanks @raymondfeng. I'll try to give you an update this week-end.

[zihehuang]

@Elindorath Any update on this issue? It seems that the connector is trying to add the column and set the NOT NULL attribute at the same time.

The way I worked around it was to drop the "required": true field and add the column to the database first. I then manually set the value of the column in Postgres. However, this is no different from doing everything manually and defeats the purpose of using a connector.

[kutsyk]

Is this fixed?

[bvanleeuwen1995]

To me this seems to be still a bug, either defaultFn or default is not honerred during migrations and it will fail.

[ptmccarthy]

I'm still running into this issue today

[bartshappee]

I ran into this today as well, the manual workaround is dangerous in the long term

[devpascoe]

same, looks like code isn't merged to master yet.
until then .... ;) npm install --save https://github.com/JumpLao/loopback-connector-postgresql.git
but .... looks like columnDbDefault isn't looking for defaultFn only default. Its not using the same default value checking as found in lookback-datasource-juggler lib/model.js _initProperties.

[bitmage]

I'm running into this today, and it's breaking our production deploy.

[bitmage]

Ended up running manual ALTER statements. 👎

[kgrvamsi]

@raymondfeng @bajtos need your help here how to resolve this issue?is this fix part of the connector or we need to do this patch on the existing library to bypass the main issue?

[piuspbd]

Still running into the issue today.

[sraddhan]

For those who end up here and are wondering about the status of the issue, there's similar issue reported which is open as of this moment. here is the link.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

This issue has been closed due to continued inactivity. Thank you for your understanding. If you believe this to be in error, please contact one of the code owners, listed in the CODEOWNERS file at the top-level of this repository.

[ketansp]

Need to open this again. This is still an issue in 2024.