Accept PGDATABASE env var in test/init.js #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I am happy to delegate code reviews to @strongloop/fa-db-connectors for the future. |
superkhau
added a commit
that referenced
this pull request
Oct 12, 2016
superkhau
added a commit
that referenced
this pull request
Oct 12, 2016
0candy
added a commit
that referenced
this pull request
Oct 14, 2016
* Add connectorCapabilities global object (#179) (Nicholas Duffy) * Accept PGDATABASE env var in test/init.js (#178) (Simon Ho) * Remove unused prefix from test env vars (#176) (Simon Ho) * Fix #123: Set default value during autoupdate. (#167) (Samuel Reed) * Update translation files - round#2 (#170) (Candy) * Add translated files (gunjpan) * Update deps to loopback 3.0.0 RC (Miroslav Bajtoš) * Use juggler@3 for running tests (Candy) * Add eslint infrastructure (Loay) * Revert "Add eslint infrastructure" (Loay) * Fix CI Failure (Loay) * test: accept more env vars on CI (Ryan Graham) * test: use 'emptytest' database as default (Ryan Graham) * test: seed DB with test schema before running (Ryan Graham) * test: separate dbconfig from datasource (Ryan Graham) * test: replace tables.sql with full schema dump (Ryan Graham) * Refactor (jannyHou) * Upgrade version (jannyHou) * Globalize discover.js (jannyHou) * Update URLs in CONTRIBUTING.md (#150) (Ryan Graham)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #176 (comment)
@bajtos PTAL
cc @strongloop/fa-db-connectors