Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(booter-lb3app): bind lb3 models #5361

Merged
merged 1 commit into from
May 10, 2020
Merged

feat(booter-lb3app): bind lb3 models #5361

merged 1 commit into from
May 10, 2020

Conversation

jannyHou
Copy link
Contributor

@jannyHou jannyHou commented May 7, 2020

Implements #5299

Bind LB3 models to booter.

All credit goes to @nabdelgadir 🙇‍♀️ her spike PR has very detailed code.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

emonddr
emonddr approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@emonddr emonddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Raymond's suggestions.

@dhmlau dhmlau added this to the May 2020 milestone May 8, 2020
@jannyHou jannyHou merged commit 914234e into master May 10, 2020
@jannyHou jannyHou deleted the bind-lb3-model branch May 10, 2020 16:48
@bajtos bajtos mentioned this pull request May 14, 2020
Merged
3 tasks
@jannyHou jannyHou mentioned this pull request May 14, 2020
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raymondfeng raymondfeng raymondfeng approved these changes

@emonddr emonddr emonddr approved these changes

@deepakrkris deepakrkris Awaiting requested review from deepakrkris

@hacksparrow hacksparrow Awaiting requested review from hacksparrow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.
4 participants
@jannyHou @raymondfeng @emonddr @dhmlau