docs: update "LB4 Component Migration" spike proposal #5427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link to follow-up issues for the following areas: - Services: #5424 - API transports: #5425 - Instrospection: #5426 Propose to not write any migration guide for auth/auth extensions yet. Add a placeholder page for migration of Models, finalize LB4 sidebar and the component-migration overview page. Signed-off-by: Miroslav Bajtoš <[email protected]>
bajtos
commented
May 14, 2020
| example)._ | ||
| _LB3 typically uses component configuration. I think in LB4, we can use | ||
| `@configure` specific to each service (see the logger extension for an | ||
| example)._ |
There was a problem hiding this comment.
Those two blocks are just whitespace changes, I removed the extra - bullet point.
| will need to decide if it's enough to inject LB4 Repository to a component | ||
| or if we need to inject model/entity classes too. Also note that | ||
| `DefaultCrudReposiory` class provides a public instance property | ||
| `entityClass` referencing the model/entity it's bound to._ |
There was a problem hiding this comment.
Updated the text to accommodate #5361
11 tasks
emonddr
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to follow-up issues for the following areas:
Propose to not write any migration guide for auth/auth extensions yet.
Add a placeholder page for migration of Models, finalize LB4 sidebar and the component-migration overview page.
This pull request resolves most of the remaining tasks in #4099 with the exception of "Migrate Models, Entities and Repositories", for which I'll open a new pull request (I have some content to include in the migration docs).
@raymondfeng @jannyHou @emonddr: please review
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated👉 Check out how to submit a PR 👈