Add background colour option to tiles operation (#1923) #1924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm it seems the tests fail in regards to skipBlanks, but the PR doesn't touch that code. Any idea what's going on here? Thanks! |
|
Thanks for the PR, I think the test failures are due to the need to match the number of channels in the "background" with the number of channels in the image. Try conditionally using |
|
OK that seemed to do the trick. It can now set the tiles background colour and passes the tests. I've committed the changes but it's now reporting coverage failure? |
lovell
requested changes
Oct 25, 2019
lovell
approved these changes
Oct 25, 2019
|
Brilliant, thank you Paul. |
lovell
added a commit
that referenced
this pull request
Oct 26, 2019
9 tasks
Repository owner
deleted a comment from
caioaugusto1998
Dec 6, 2019
This comment was marked as off-topic.
This comment was marked as off-topic.
Repository owner
locked and limited conversation to collaborators
Dec 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done the best I can to add background colour as an option for the tile() method. I may have missed something here as I'm not a C++ programmer. Let me know your thoughts. Thanks.