Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Node 13 to CI #1932

Merged
merged 3 commits into from
Oct 23, 2019
Merged

Add Node 13 to CI #1932

merged 3 commits into from
Oct 23, 2019

Conversation

nstepien
Copy link
Contributor

@nstepien nstepien commented Oct 23, 2019 •
edited
Loading

nstepien
nstepien commented Oct 23, 2019
View reviewed changes
.travis.yml Outdated
@@ -66,3 +82,8 @@ matrix:
osx_image: xcode9.2
language: node_js
node_js: "12"
- name: "OS X - Node 13"
os: osx
osx_image: xcode11.2
Copy link
Contributor Author

@nstepien nstepien Oct 23, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changelog:

The minimum Xcode version supported for macOS was increased to 10. It is still possible to build Node.js with Xcode 8 but this may no longer be the case in a future v13.x release

For reference: https://docs.travis-ci.com/user/reference/osx/#macos-version

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use xcode10 here? That way we'll still support OS X 10.13 (rather than jumping to 10.14).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 👍

@nstepien nstepien marked this pull request as ready for review October 23, 2019 15:22
@nstepien
Copy link
Contributor Author

@lovell The PR itself is ready for review, but CI is giving random failures, unrelated to the Node update AFAICT.

@coveralls
Copy link

coveralls commented Oct 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 99.757% when pulling 1676653 on MayhemYDG:patch-1 into e627f6d on lovell:master.

lovell
lovell requested changes Oct 23, 2019
View reviewed changes
Copy link
Owner

@lovell lovell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, one small comment inline otherwise this is good to merge. I've re-started the failed CI jobs as it looks like there was/is too much load on the nodejs.org site.

.travis.yml Outdated
@@ -66,3 +82,8 @@ matrix:
osx_image: xcode9.2
language: node_js
node_js: "12"
- name: "OS X - Node 13"
os: osx
osx_image: xcode11.2
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use xcode10 here? That way we'll still support OS X 10.13 (rather than jumping to 10.14).

@lovell lovell merged commit d82a6ee into lovell:master Oct 23, 2019
@lovell
Copy link
Owner

lovell commented Oct 23, 2019

Merci beaucoup!

@nstepien nstepien deleted the patch-1 branch October 23, 2019 18:28
@nstepien
Copy link
Contributor Author

🎉

Hoping for a release soon for the prebuilt binaries. 🙂

@lovell
Copy link
Owner

lovell commented Oct 23, 2019

Please subscribe to #1909 for updates.

lovell added a commit that referenced this pull request Oct 26, 2019
@lovell
Changelog entries for #1924 #1932
2f2276e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovell lovell lovell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nstepien @coveralls @lovell