Emit close event when stream is complete

[driannaude]

Fixes #2897
Fixes #2898

[lovell]

Thank you very much for the PR. Are you able to add a couple of unit tests to cover this logic? This should help prevent any future regression.

[driannaude]

Sure thing! I'll take a look over the next couple of days when I get a chance.

[coveralls]

Coverage increased (+0.0002%) to 99.904% when pulling f952e45 on driannaude:master into 079bd7b on lovell:main.

[lovell]

Brilliant, thank you Drian!

[arsonik]

Hey guys !
good job on the bug fix
But any idea on getting rid of this error though ?
(that was probably working because of the bug 🙈)

    private async handlePicture(resource: FileUpload, hash: string): Promise<MediaInformation> {
        const transformer = sharp().rotate().jpeg();
        await this.upload(resource.createReadStream().pipe(transformer), redacted({ hash, type: MediaType.Picture }));

    private upload(resource: Options['params']['Body'], name: string) {
        return new Upload({
            client: S3Snap,
            params: {
                Bucket: awsSnapConfig.bucket,
                Key: name,
                Body: resource,
            },
        })

ERROR

Error [ERR_STREAM_PREMATURE_CLOSE]: Premature close
    at new NodeError (node:internal/errors:372:5)
    at Sharp.onclose (node:internal/streams/end-of-stream:136:30)
    at Sharp.emit (node:events:527:28)
    at Sharp.emit (node:domain:475:12)
    at Object.<anonymous> (node_modules/sharp/lib/output.js:1139:16)
    at Object.topLevelDomainCallback (node:domain:152:15)
    at Object.callbackTrampoline (node:internal/async_hooks:128:24)

[lovell]

@arsonik If you still require help, please open a new question at https://github.com/lovell/sharp/issues/new?labels=question&template=question.md - please remember that you'll need to remove non-sharp dependencies from your question, including removing any possible networking problems, as part of this.