[darjeeling] Instantiate Darjeeling on `master` #25156

Razer6 · 2024-11-15T11:19:55Z

We are finally able to instantiate Darjeeling from the master branch. This commit is separated into 3 commits:

Gate SEC_CM's in pinmux that are used only when hardware strap sampling is active. This is only the case for Earlgrey and English Breakfast
Add the HJSON files that define Darjeeling. That includes the top-level HKSON and all Crossbar definitions
Add Darjeeling to hw/Makefile and run make -C hw top_and_cmdgen to generate Darjeeling and all other artifacts.

Razer6 · 2024-11-15T11:38:08Z

The verible lint job fails because this PR is exceeding the maximum number of files.

andreaskurth · 2024-11-15T14:29:26Z

The verible lint job fails because this PR is exceeding the maximum number of files.

Here's the output of a manual Verible lint run on the files changed by this PR:

hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:30:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:32:26: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:34:30: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:36:32: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:37:32: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:38:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:39:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:40:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:41:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:42:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:43:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:44:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:45:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:46:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:47:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:48:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:49:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:51:24: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:52:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:53:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:54:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:55:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:56:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:57:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:58:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:59:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:60:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:61:16: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:62:18: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:63:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:64:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:65:20: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:66:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:67:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:68:30: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:69:33: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:70:32: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:71:33: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:72:32: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:73:16: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:74:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:75:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:76:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:77:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:78:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:79:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:80:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:81:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:82:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:83:28: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:84:18: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:85:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:86:17: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:87:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:88:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:89:21: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:90:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:91:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:92:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:93:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:94:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:95:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:96:26: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:97:24: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:98:26: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:99:36: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:100:35: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:101:26: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:102:16: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:103:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:104:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:105:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:106:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:107:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:108:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:109:22: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:110:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:111:27: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:112:23: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:113:26: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:114:25: syntax error at token "("
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:9:61: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:10:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:11:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:12:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:23:68: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:24:73: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:25:73: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:16:63: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:17:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:18:87: syntax error at token "\"
hw/top_darjeeling/dv/autogen/tb__xbar_connect.sv:19:58: syntax error at token "\"
hw/top_darjeeling/ip/xbar_dbg/dv/autogen/tb__xbar_connect.sv:9:1-10: preprocessing error at token "`DRIVE_CLK" : Error expanding macro identifier, might not be defined before.
hw/top_darjeeling/ip/xbar_main/dv/autogen/tb__xbar_connect.sv:9:1-10: preprocessing error at token "`DRIVE_CLK" : Error expanding macro identifier, might not be defined before.
hw/top_darjeeling/ip/xbar_mbx/dv/autogen/tb__xbar_connect.sv:9:1-10: preprocessing error at token "`DRIVE_CLK" : Error expanding macro identifier, might not be defined before.
hw/top_darjeeling/ip/xbar_peri/dv/autogen/tb__xbar_connect.sv:9:1-10: preprocessing error at token "`DRIVE_CLK" : Error expanding macro identifier, might not be defined before.
hw/top_darjeeling/rtl/autogen/top_darjeeling.sv:72:101-106: Line length exceeds max: 100; is: 106 [Style: line-length] [line-length]

No real violations IMO

Signed-off-by: Robert Schilling <[email protected]>

andreaskurth · 2024-11-15T15:03:41Z

A manual run of Check for and block unauthorized changes with

git diff --name-only $(git merge-base origin/master HEAD)..HEAD > changes-file
ci/scripts/check-pr-changes-allowed.py --pr-number 25156 changes-file

passed; thus there are no changes to authorize in this PR.

andreaskurth

This PR seems huge, but most changes are autogenerated and contained within one commit, which contains the command to generate them. I cross-checked the autogenerated file by repeating the command, and it matches. (This is in addition to a CI check that should catch mismatches, I think.)

LGTM!

Add top_darjeeling.hjson and all xbar.hjson files. Signed-off-by: Robert Schilling <[email protected]>

Command run: make -C hw top_and_cmdgen Signed-off-by: Robert Schilling <[email protected]>

Signed-off-by: Robert Schilling <[email protected]>

Add jtag_id_pkg.sv, padring.sv, scan_role_pkg, ibex_pmp_reset_pkg.sv Signed-off-by: Robert Schilling <[email protected]>

The mi/dio signals are used in both cases, hardware strap sampling enabled an not. Signed-off-by: Robert Schilling <[email protected]>

andreaskurth

Changes related to FuseSoC / virtual cores and linting / dvsim flows are needed to resolve conflicts with Earlgrey. This is ongoing work; withdrawing approval for now (architecturally still LGTM, though).

Razer6 requested review from a team as code owners November 15, 2024 11:19

Razer6 requested review from matutem, jwnrt, timothytrippel, andreaskurth and vogelpi and removed request for a team, matutem, jwnrt and timothytrippel November 15, 2024 11:19

Razer6 added Component:MultiTop Component:Darjeeling labels Nov 15, 2024

Razer6 force-pushed the darjeeling-instantiation branch from dc9910a to 539cfad Compare November 15, 2024 11:30

andreaskurth changed the title ~~[darjeeling] Instantiate Darjeeling from Master~~ [darjeeling] Instantiate Darjeeling on master Nov 15, 2024

[hw,pinmux] Gate countermeasures only used for HW strampling

c39bc13

Signed-off-by: Robert Schilling <[email protected]>

andreaskurth approved these changes Nov 15, 2024

View reviewed changes

Razer6 force-pushed the darjeeling-instantiation branch from 31b3416 to 1b61155 Compare November 15, 2024 15:16

Razer6 added 5 commits November 15, 2024 16:32

[darjeeling] Add HJSON files to define Darjeeling

09ea551

Add top_darjeeling.hjson and all xbar.hjson files. Signed-off-by: Robert Schilling <[email protected]>

[darjeeling] Generate Darjeeling from HJSON files

963d6e3

Command run: make -C hw top_and_cmdgen Signed-off-by: Robert Schilling <[email protected]>

[hw,keymgr,rtl] Add keymgr_common package for sharing with keymgr_dpe

e3e619d

Signed-off-by: Robert Schilling <[email protected]>

[darjeeling] Add core and linter files for Darjeeling

1f2e53c

Signed-off-by: Robert Schilling <[email protected]>

[darjeeling,lint] Re-enable uncommented linting rules

d0f0cd3

Signed-off-by: Robert Schilling <[email protected]>

Razer6 force-pushed the darjeeling-instantiation branch from 1b61155 to d0f0cd3 Compare November 15, 2024 15:33

[darjeeling] Add top-dependend RTL files

fe8fbe2

Add jtag_id_pkg.sv, padring.sv, scan_role_pkg, ibex_pmp_reset_pkg.sv Signed-off-by: Robert Schilling <[email protected]>

Razer6 force-pushed the darjeeling-instantiation branch from d10c3aa to fe8fbe2 Compare November 15, 2024 17:09

[hw,pinmux,rtl] Move signal definition outside of param block

7eb4a0e

The mi/dio signals are used in both cases, hardware strap sampling enabled an not. Signed-off-by: Robert Schilling <[email protected]>

andreaskurth requested changes Nov 18, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[darjeeling] Instantiate Darjeeling on `master` #25156

[darjeeling] Instantiate Darjeeling on `master` #25156

Razer6 commented Nov 15, 2024

Razer6 commented Nov 15, 2024

andreaskurth commented Nov 15, 2024 •

edited

Loading

andreaskurth commented Nov 15, 2024

andreaskurth left a comment

andreaskurth left a comment

[darjeeling] Instantiate Darjeeling on master #25156

Are you sure you want to change the base?

[darjeeling] Instantiate Darjeeling on master #25156

Conversation

Razer6 commented Nov 15, 2024

Razer6 commented Nov 15, 2024

andreaskurth commented Nov 15, 2024 • edited Loading

andreaskurth commented Nov 15, 2024

andreaskurth left a comment

Choose a reason for hiding this comment

andreaskurth left a comment

Choose a reason for hiding this comment

[darjeeling] Instantiate Darjeeling on `master` #25156

[darjeeling] Instantiate Darjeeling on `master` #25156

andreaskurth commented Nov 15, 2024 •

edited

Loading