Merge pull request #1166 from koic/deprecate_safe_level_of_erb_new_in…

…_ruby_2_6 Deprecate safe_level of ERB.new in Ruby 2.6
lsegal · May 28, 2018 · 9a1a329 · 9a1a329
2 parents df24cbe + 707663a
commit 9a1a329
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/benchmarks/erb_vs_erubis.rb b/benchmarks/erb_vs_erubis.rb
@@ -45,7 +45,7 @@ def erb_with(str, x) Erubis::TinyEruby.new(str) end
   x.report("erb") do
     eval <<-eof
        module YARD; module Templates; module Template
-        def erb_with(str, x) ERB.new(str, nil) end
+        def erb_with(str, x) ERB.new(str) end
       end end end
     eof
 

diff --git a/benchmarks/template_erb.rb b/benchmarks/template_erb.rb
@@ -12,7 +12,7 @@ module YARD
     module Templates
       module Template
         def erb(section, &block)
-          erb = ERB.new(cache(section), nil)
+          erb = ERB.new(cache(section))
           erb.filename = cache_filename(section).to_s
           erb.result(binding, &block)
         end

diff --git a/lib/yard/templates/template.rb b/lib/yard/templates/template.rb
@@ -348,7 +348,11 @@ def erb_file_for(section)
       end
 
       def erb_with(content, filename = nil)
-        erb = ERB.new(content, nil, options.format == :text ? '<>' : nil)
+        erb = if ERB.instance_method(:initialize).parameters.assoc(:key) # Ruby 2.6+
+                ERB.new(content, :trim_mode => options.format == :text ? '<>' : nil)
+              else
+                ERB.new(content, nil, options.format == :text ? '<>' : nil)
+              end
         erb.filename = filename if filename
         erb
       end