Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate safe_level of ERB.new in Ruby 2.6 #1166

Merged
merged 1 commit into from
May 28, 2018
Merged

Deprecate safe_level of ERB.new in Ruby 2.6 #1166

merged 1 commit into from
May 28, 2018

Conversation

koic
Copy link
Contributor

@koic koic commented May 2, 2018

Description

The interface of ERB.new will change from Ruby 2.6.

Add :trim_mode and :eoutvar keyword arguments to ERB.new.
Now non-keyword arguments other than first one are softly deprecated
and will be removed when Ruby 2.5 becomes EOL. [Feature #14256]

https://github.com/ruby/ruby/blob/2311087b685e8dc0f21f4a89875f25c22f5c39a9/NEWS#stdlib-updates-outstanding-ones-only

Completed Tasks

  • I have read the Contributing Guide.
  • The pull request is complete (implemented / written).
  • Git commits have been cleaned up (squash WIP / revert commits).
  • I wrote tests and ran bundle exec rake locally (if code is attached to PR).

@koic
Deprecate safe_level of ERB.new in Ruby 2.6
707663a 
The interface of `ERB.new` will change from Ruby 2.6.

> Add :trim_mode and :eoutvar keyword arguments to ERB.new.
> Now non-keyword arguments other than first one are softly deprecated
> and will be removed when Ruby 2.5 becomes EOL. [Feature #14256]

https://github.com/ruby/ruby/blob/2311087b685e8dc0f21f4a89875f25c22f5c39a9/NEWS#stdlib-updates-outstanding-ones-only
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.005%) to 93.493% when pulling 707663a on koic:deprecate_safe_level_of_erb_new_in_ruby_2_6 into d6491b4 on lsegal:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 2, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.005%) to 93.493% when pulling 707663a on koic:deprecate_safe_level_of_erb_new_in_ruby_2_6 into d6491b4 on lsegal:master.

@lsegal lsegal merged commit 9a1a329 into lsegal:master May 28, 2018
@lsegal
Copy link
Owner

lsegal commented May 28, 2018

Thank you!

lsegal added a commit that referenced this pull request May 28, 2018
@lsegal
Tag release v0.9.13
dff428a 
References:
  #1056, #1144, #1145, #1152, #1154, #1156, #1166, #1167,
  #1168, #1169, #14256, #610
@koic koic deleted the deprecate_safe_level_of_erb_new_in_ruby_2_6 branch May 29, 2018 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koic @coveralls @lsegal