-
-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sport icons #1304
Merged
Merged
Add sport icons #1304
Changes from 18 commits
Commits
Show all changes
69 commits
Select commit
Hold shift + click to select a range
3d8cc6c
Add `basketball` icon
danielbayley 4504c14
Add `tennis-ball` icon
danielbayley 1ffc226
Add `bat-ball` (table tennis/ping-pong) icon
danielbayley c0fc3c9
Add `football-soccer` icon
danielbayley a00b221
Add `goal-net` icon
danielbayley a4ed15c
Add (American) `football` icon
danielbayley 6f25d82
Add (American) `football-helmet` icon
danielbayley af3a0d5
Refine `basketball` icon
danielbayley 88ffa2d
Refine `bat-ball` icon
danielbayley 5403e1f
Refine `football` icon
danielbayley 705fc7c
Add `bowling-ball` icon
danielbayley 71527f7
Add `bowling` icon
danielbayley ad25b9d
Add `bowling-pins` icon
danielbayley 8966720
Add `shuttlecock` icon
danielbayley 16cbdaa
Add `hockey` icon
danielbayley fafc0dd
Add `ice-hockey` icon
danielbayley 5f26d5b
Add `hockey-mask` icon
danielbayley 6ad5dbb
Add `ice-skate` icon
danielbayley 51af1d4
Update icons/football.svg
danielbayley 0289676
Update icons/basketball.svg
danielbayley 1ad9830
Improve sports icons metadata
danielbayley 79d7352
Refine `ice-skate` icon
danielbayley 72ef9b1
Refine `hockey-mask` icon
danielbayley 3722007
Refine `football-helmet` icon
danielbayley 5e616fc
Refine `ice-skate` icon
danielbayley aa89af4
Fix `hockey` icon metadata
danielbayley 7f39c14
Add `steering-wheel` icon
danielbayley bef9421
Add `gearbox` icon
danielbayley c381200
Add `volleyball` icon
danielbayley b2e05e3
Improve metadata
danielbayley 6d6aab1
Add `tennis-racket` icon
danielbayley d70d001
Add `baseball` icon
danielbayley 8522ea7
Add `golf-ball-tee` icon
danielbayley 7ac5682
Add `golf-ball-flag-hole` icon
danielbayley 89ac3ec
Add `cricket-ball` icon
danielbayley d249f18
Add `cricket-wicket` icon
danielbayley 3ea349f
Improve metadata
danielbayley 8ee26bd
Rename/refine `golf-ball-tee` to `golf-driver`
danielbayley 6a44749
Add `golf-putter` icon
danielbayley c3a5b91
Refine `bowling-pins` icon
danielbayley ca0a0e2
Refine `bowling` icon
danielbayley d0e3aa6
Add `football-soccer-pitch` icon
danielbayley cc311da
Add `rugby` icon
danielbayley 6d8b81f
Improve metadata
danielbayley 365ea73
Add `football-goal` icon
danielbayley 1592887
Rename `football-soccer` to `soccer-ball`
danielbayley a6c89f2
Rename `football-soccer-pitch` to `soccer-pitch`
danielbayley f895e3a
Rename `golf-ball-flag-hole` to just `golf`
danielbayley f5e2bc1
Add `gearbox-square` icon
danielbayley 008045b
Add `snooker` icon
danielbayley f8151c5
Add `target-arrow` (archery) icon
danielbayley 30705ae
Improve `target` metadata
danielbayley 6aaf1d1
Refine `soccer-ball` icon
danielbayley df6b531
Improve metadata
danielbayley e95d17b
Add `motor-racing-helmet` icon
danielbayley 0b44601
Update icons/bowling.svg
danielbayley 3352d43
Update icons/bowling.svg
danielbayley f68a54a
Refine `bowling-pins` icon
danielbayley c370ca1
Refine `bowling` icon
danielbayley 9f72045
Resolve conflict with `target` metadata
danielbayley 9dd3b4b
Update icons/bowling.svg
danielbayley 09bcd05
Refine/optimise `bowling`[`-pins`]
danielbayley fe3d2fa
Revert "Add `snooker` icon"
danielbayley 73dc70a
Revert "Add `golf-putter` icon"
danielbayley e4e7e8c
Remove `golf`[`-ball-flag-hole`] icon
danielbayley a1e0ad0
Remove `bowling-pins` icon
danielbayley 7a64410
Revert "Add `bowling-ball` icon"
danielbayley 2de6a05
Revert "Add `shuttlecock` icon"
danielbayley 17a5403
Refine `football` icon
danielbayley File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"bounce", | ||
"hoop", | ||
"net", | ||
"court", | ||
"score" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"table tennis", | ||
"ping-pong", | ||
"whiff-whaff", | ||
"paddle", | ||
"racquet", | ||
"racket", | ||
"net", | ||
"bounce", | ||
"score" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"ten-pin", | ||
"10 pin", | ||
"pins", | ||
"lane", | ||
"alley", | ||
"strike", | ||
"spare", | ||
"score", | ||
"indoor sports", | ||
"heavy" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"ten-pin", | ||
"10 pin", | ||
"ball", | ||
"lane", | ||
"alley", | ||
"strike", | ||
"spare", | ||
"score", | ||
"indoor sports", | ||
"heavy" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"ten-pin", | ||
"10 pin", | ||
"pins", | ||
"ball", | ||
"lane", | ||
"alley", | ||
"strike", | ||
"spare", | ||
"score", | ||
"indoor sports", | ||
"heavy" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"american", | ||
"touchdown", | ||
"kick", | ||
"pitch", | ||
"goal", | ||
"score", | ||
"bounce" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
danielbayley marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"soccer", | ||
"futbol", | ||
"kick", | ||
"pitch", | ||
"goal", | ||
"score", | ||
"bounce" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
danielbayley marked this conversation as resolved.
Show resolved
Hide resolved
|
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"rugby", | ||
"american", | ||
"touchdown", | ||
"kick", | ||
"pitch", | ||
"team", | ||
"goal", | ||
"score", | ||
"bounce" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"score", | ||
"football", | ||
"futbol", | ||
"soccer", | ||
"ice hockey", | ||
"posts", | ||
"crossbar", | ||
"kick", | ||
"pitch", | ||
"penalty" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not that much of a goal feel for me here, but also no clue how to do this any better. |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{ | ||
"$schema": "../icon.schema.json", | ||
"tags": [ | ||
"ice hockey", | ||
"puck", | ||
"goalkeeper", | ||
"goalie", | ||
"team", | ||
"protective equipment", | ||
"protection", | ||
"padding", | ||
"face", | ||
"winter sports", | ||
"horror", | ||
"scary", | ||
"scared", | ||
"halloween", | ||
"costume" | ||
], | ||
"categories": [ | ||
"sports", | ||
"gaming" | ||
] | ||
} |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think without the context of the bowling ball, these are a bit hard to pin (🤪), I'd vote to just drop them (🤪), two bowling related icons are already plenty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh mic drop there! 🙉🙈😅
@karsa-mistmere Just to represent it probably yes, although I did have in mind icons for
strike
andspare
(with the obvious corresponding use case)… Something roughly along the lines of these: