Add sport icons

[danielbayley]

Alternatives for football (/rugby-ball?) Maybe we should prefer to cover both with a single icon…?)

Contributes to #119

---

Leaving removed icons here, for reference…

[vercel]

@danielbayley is attempting to deploy a commit to the Lucide Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

Added or changed icons

Preview cohesion

Preview stroke widths

Icon X-rays

[karsa-mistmere]

Nice work! I also had some of these, but I think most of yours are either highly superior or pretty much exactly the same, with the exception of basketball, in which case I prefer mine (mostly because it's at a 45deg angle), and I also have bowling-ball and bowling:

Edit 1: I also have tennis-racket, but that one's a bit weak:

Edit 2: Your football also has some guideline violations, but all in all I prefer your approach to mine:

Maybe something like this as something inbetween?

[danielbayley]

Nice work! I also had some of these, but I think most of yours are either highly superior or pretty much exactly the same, with the exception of basketball, in which case I prefer mine (mostly because it's at a 45deg angle), and I also have bowling-ball and bowling

@karsa-mistmere Thanks, ha of course you did! Yeah cool with the basketball… was just trying to differentiate more between tennis-ball.

Nice, like the bowling ball idea!

Your football also has some guideline violations, but all in all I prefer your approach to mine

I have a bunch of iterations. Will post them soon…

Do you think soccer-ball would be a better name than football-soccer? (Americans with their stupid names… That ball clearly isn’t for kicking around with the foot 🤪)

[jguddas]

Very cute icons 👍

[jguddas]

Not that much of a goal feel for me here, but also no clue how to do this any better.

[danielbayley]

@ericfennis Implemented those changes, and left the removed icons above, for reference…

"shuttlecock", and "snooker" are too specific

Are those any less of a sport than the others? 🤷🏻‍♂️ Seems a shame to waste shuttlecock…

"soccer", doesn't use most parts of the world the word: "football"?

Yeah, myself included! Are you thinking we should go with football and football-american? It just seemed like soccer/football was cleaner…

cc: @karsa-mistmere @jguddas

[jguddas]

american-football/soccer-ball, just due to being descriptive, football means a lot of different sports depending on where in the world you are from.

And the line in the middle of the american-football makes gives weird pixel artifacts in 1x size, what about removing it?

[danielbayley]

the line in the middle of the american-football makes gives weird pixel artifacts in 1x size, what about removing it?

@jguddas What about this?

[jguddas]

the line in the middle of the american-football makes gives weird pixel artifacts in 1x size, what about removing it?

@jguddas What about this?

I like it, and no artifacts 👍

[github-actions]

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

[ygd]

soccer-pitch looks a bit to heavy next to others. needs maybe a little tweak

[ygd]

soccer-ball looks like a life ring. needs a little tweak as well

[ericfennis]

@danielbayley I agree with @ygd. It need some tweaking. 🤔

[ygd]

from an agile point of view, PRs with multiple icons are slowing down shipping new icons.

eg. a PR with 10 icons, 9 are good but 1 is not so all icons are on hold and cannot be shipped. They must wait until the one which is not looking good is fixed.

I suggest PRs containing only one icon.

am I missing something, @ericfennis?

[ericfennis]

@ygd Yess you are right. A PR with a lot of icons is harder to review.
But sometimes multiple icons can have shared styling, for example same size of the ball or the same handle of the stick in this case. The benefit of having it in one PR is better to review the icon design "cohesion" of the same "theme".
It's important to have them matching.
So for me 1 icon per PR is not the "ideal" solution, also because every merge is triggering a release.
I think we need to find a balance, and be a bit stricter on splitting a PR if 80-90% of the icons are ready to merge.

[ericfennis]

This PR is merged to the lab branch. This PR does not match our PR template, which requires valid use cases. To move on we merged this PR to the lab branch, which will be moved to a separate repo in the future.

[danielbayley]

soccer-pitch looks a bit to heavy next to others. needs maybe a little tweak

soccer-ball looks like a life ring. needs a little tweak as well

I agree with @ygd. It need some tweaking.

@ericfennis I have some of these tweaks ready to go… but it’s a moving target! What is the procedure with this new lab branch? Do I just push everything to that branch now, for requested changes to all icons (including now many other PRs)?

[ygd]

@ygd Yess you are right. A PR with a lot of icons is harder to review.

But sometimes multiple icons can have shared styling, for example same size of the ball or the same handle of the stick in this case. The benefit of having it in one PR is better to review the icon design "cohesion" of the same "theme".

It's important to have them matching.

So for me 1 icon per PR is not the "ideal" solution, also because every merge is triggering a release.

I think we need to find a balance, and be a bit stricter on splitting a PR if 80-90% of the icons are ready to merge.

Good point. Maybe grouping similar icons, like balls or bottles, in a PR makes more sense.

Do you think it is good to write this down in contribution guidelines?

[ericfennis]

@danielbayley You can create PR to make changes on the lab branch.
You can still make PRs to the main branch for new icons, but make sure you have clear use cases for the icons.

[danielbayley]

You can still make PRs to the main branch for new icons, but make sure you have clear use cases for the icons.

@ericfennis Does this imply that all icons already in this PR—and all others merged into lab—don’t have valid use cases?