Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icons): added volleyball icon #1980

Merged
merged 3 commits into from
Oct 8, 2024

Conversation

jguddas
Copy link
Member

@jguddas jguddas commented Mar 14, 2024

#1978

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Adds new volleyball icon

Icon use case

  • showing volleyball courts on a map

Alternative icon designs

Icon Design Checklist

Concept

  • I have provided valid use cases for each icon.
  • I have not added any a brand or logo icon.
  • I have not used any hate symbols.
  • I have not included any religious or political imagery.

Author, credits & license

  • The icons are solely my own creation.
  • The icons were originally created in Add sport icons #1304 by @danielbayley
  • I've based them on the following Lucide icons:
  • I've based them on the following design:

Naming

  • I've read and followed the naming conventions
  • I've named icons by what they are rather than their use case.
  • I've provided meta JSON files in icons/[iconName].json.

Design

  • I've read and followed the icon design guidelines
  • I've made sure that the icons look sharp on low DPI displays.
  • I've made sure that the icons look consistent with the icon set in size, optical volume and density.
  • I've made sure that the icons are visually centered.
  • I've correctly optimized all icons to two points of precision.

Before Submitting

@github-actions github-actions bot added 🎨 icon About new icons 🫧 metadata Improved metadata labels Mar 14, 2024
Copy link

Added or changed icons

icons/volleyball.svg

Preview cohesion icons/square-stack.svg
icons/volleyball.svg
icons/circle-chevron-up.svg
Preview stroke widths icons/volleyball.svg
icons/volleyball.svg
icons/volleyball.svg
DPI Preview (24px) icons/volleyball.svg
Icon X-rays icons/volleyball.svg

@jguddas
Copy link
Member Author

jguddas commented Mar 14, 2024

Is that a sufficient enough use case?
Is the name good, or should it be ball-volleyball instead?

@danielbayley
Copy link
Member

danielbayley commented Mar 14, 2024

Nice one @jguddas, do all of my previous icons that got merged into lab have to be submitted one at a time now? 😖

should it be ball-volleyball instead?

Seems redundant… Maybe ball-volley? If we want them all sorted by ball-*

@jguddas
Copy link
Member Author

jguddas commented Mar 14, 2024

do all of my previous icons that got merged into lab have to be submitted one at a time now? 😖

They should always be submitted one at a time IMO, otherwise they are never gonna get merged.


I have this little script for now. Ideally lucide studio would handle moving things between branches.

grab-lab () {
  git fetch origin lab;
  git checkout main;
  git checkout -b studio/$1;
  git checkout origin/lab icons/$1.svg icons/$1.json
  git commit -m "chore: pull `$1` icon from lab branch"
}

@danielbayley
Copy link
Member

I have this little script for now.

@jguddas Nice, maybe this can be simplified, and expanded on with gh CLI

@karsa-mistmere
Copy link
Member

I think just volleyball is fine, I'd expect ball-volley to be a ball that volleys (which a volleyball does, of course, but still). It's not like square- or circle-, I don't think it's necessary for various sport icons to be next to each other when sorted.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

Copy link

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 icon About new icons 🫧 metadata Improved metadata Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants