-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.42 and use subslices pattern #42
Conversation
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
==========================================
- Coverage 94.92% 94.21% -0.72%
==========================================
Files 9 9
Lines 394 380 -14
==========================================
- Hits 374 358 -16
- Misses 20 22 +2
Continue to review full report at Codecov.
|
Nice! I added a commit to disable a clippy lint (that suggested we change an error name, which is a major version bump...), and then it triggered other 15 warnings related to returning a So, I added a The final clippy lint was for replacing the |
This pull request increase the minimal supported rust version to 1.42, because
object
one of our dependencies requires it.But I'm also taking the opportunity to use the subslices pattern which are available since version 1.42. These changes mean that we no longer use the values associated with the
Format
enum, so I'm removing theenum_primitive
dependency.