[MRG] Bump MSRV to 1.42 (and other dep fixes) #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## latest #1461 +/- ##
=======================================
Coverage 89.58% 89.58%
=======================================
Files 122 122
Lines 18986 18986
Branches 1455 1455
=======================================
Hits 17008 17008
Misses 1750 1750
Partials 228 228
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
luizirber
changed the title
|
Ready for review and merge @ctb |
ctb
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some dependency cleanup on the Rust side, considering that
nifflerwill soon require 1.42 and this also allows us to use all the latest versions of our dependencies.On Ubuntu all the LTS versions have Rust 1.47 available (from security updates), and Debian is
1.41on stable and1.48in testing, so it could be an issue (but I'm not aware of anyone building sourmash from source on debian with their default Rust, so...)