Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IMP: Bookmark hotkey accuracy. #29

Closed
Segergren opened this issue Sep 20, 2022 · 0 comments
Closed

IMP: Bookmark hotkey accuracy. #29

Segergren opened this issue Sep 20, 2022 · 0 comments

Comments

@Segergren
Copy link
Contributor

The current bookmarks calculate their position by calculating (Time at keypress/total time) to retrieve the position in the player (percentage %). The current implementation might be off by 1-5 seconds, is there any way to improve this?
@sonicv6 sonicv6 mentioned this issue Sep 21, 2022
Merged
lulzsun pushed a commit that referenced this issue Sep 21, 2022
@sonicv6
fix: issue #29 & refactor #24 (#30)
7516672 
* fix: Incorrect video duration.

Used ffmpeg to obtain correct video file duration.

* refactor: Refactored hotkeys to work around low-level keyboard hook.

* fix: Handle multi-inputs correctly

Refactored input checking to be cleaner and correctly handle multi-input hotkeys correctly.

* fix: Encoders not loaded on first launch.
@lulzsun lulzsun closed this as completed Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lulzsun @Segergren