Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yarn test:e2e fails if BINARY_PATH isn't set #574

Closed
NodeGuy opened this issue Mar 24, 2018 · 6 comments · Fixed by #677 or #797
Closed

yarn test:e2e fails if BINARY_PATH isn't set #574

NodeGuy opened this issue Mar 24, 2018 · 6 comments · Fixed by #677 or #797
Assignees
@jbibla

Comments

@NodeGuy
Copy link
Contributor

NodeGuy commented Mar 24, 2018

Version

0.4.3

Description

$ yarn test:e2e
...
TAP version 13
# sign in
using binary undefined
ui home: /var/folders/wj/0h36fvtj03q0y9lf0n9c0nxc0000gp/T/1fyqfh932ug
node home: /var/folders/wj/0h36fvtj03q0y9lf0n9c0nxc0000gp/T/6pw1z457nm/baseserver
unhandledRejection TypeError: "file" argument must be a non-empty string
    at normalizeSpawnArguments (child_process.js:380:11)
    at exports.spawn (child_process.js:493:38)
    at Promise (/Users/david/Documents/Tendermint/voyager/test/e2e/launch.js:119:17)
    at new Promise (<anonymous>)
    at startLocalNode (/Users/david/Documents/Tendermint/voyager/test/e2e/launch.js:118:9)
    at Promise (/Users/david/Documents/Tendermint/voyager/test/e2e/launch.js:37:13)
    at new Promise (<anonymous>)
    at launch (/Users/david/Documents/Tendermint/voyager/test/e2e/launch.js:28:15)
    at /Users/david/Documents/Tendermint/voyager/test/e2e/signin.js:10:21
    at Test.<anonymous> (/Users/david/Documents/Tendermint/voyager/node_modules/tape-promise/index.es5.js:24:17)
...

The README doesn't mention the need to set BINARY_PATH but it's used here:

https://github.com/cosmos/voyager/blob/2d30d385cacc0cf1830cd7738ab0c5d2074d0056/test/e2e/launch.js#L12

Could we use the version of Gaia found in the PATH instead of requiring the user to set an environment variable? Normally I expect yarn test to Just Work out of the box without requiring extra configuration of my shell.
@jbibla
Copy link
Collaborator

jbibla commented Apr 4, 2018

++

@faboweb
Copy link
Collaborator

faboweb commented Apr 4, 2018

We can default to the PATH gaia. But we need to provide the possibility to define the path name as the e2e tests run mainly on the CI.

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Apr 11, 2018 •
edited
Loading

How about we just put Gaia in the PATH on the CI?

@faboweb
Copy link
Collaborator

faboweb commented Apr 11, 2018 via email

@NodeGuy
Copy link
Contributor Author

NodeGuy commented Apr 12, 2018

Works for me.

@jbibla jbibla self-assigned this May 1, 2018
jbibla added a commit that referenced this issue May 9, 2018
@jbibla
closes #574
9cdb7d6 
defaults to gaia in GOPATH but should still work for circle and can be overwritten
@jbibla jbibla mentioned this issue May 9, 2018
Merged
@NodeGuy
Copy link
Contributor Author

NodeGuy commented May 24, 2018

Looks like we have a regression: Now we need two environment variables to be set in order for yarn test:e2e work:

you can try to run BINARY_PATH=$(which gaiacli) NODE_BINARY_PATH=$(which gaiad) yarn test:e2e

@mappum Can we go back to the glorious days of yarn test:e2e working?

@NodeGuy NodeGuy reopened this May 24, 2018
@okwme okwme mentioned this issue Jun 6, 2018
Merged
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb @mariopino @Bitcoinera
Fabo/fix old rewards script (#574)
c5f41a9 
* initial working state

* working, this time is true ;-)

* fix validator, comments

* fix, cleanup

* fix validator

* update comment

* Use coinReducer

* cleanup

* cleanup unused vars

* cleanup

* Flatten era rewards and then aggregate per valid

* refactored

* typo

* uüdated polkadot

* load rewards

* steps towards storing the rewards

* fix era format

* fix validator in row needs to be address

* fix gql query

* format bug

* some refactoring

* fix missing await

* correctly get api

* push validator getter inside sources

* added address to lunie reward internaly

* add address correctly

* fix variable naming

* filter empty rewards

* add height from rewards

* added query past rewards script

* calling main

* missing imports

* upsert to prevent conflicts

* flatten rewards

* fix too many labels issue

* typo

* write for each validator

* await finishing

* add validators correctly to the store

* remove timing for rewards

* correctly write validator and filter 0

* extract missing vals

* query rewards for polkadot from db

* run rewards getter in parallel

* adjust get rewards script

* add store caching

* fix fs functions callbacks

* fix stuff

* fix more stuff. working

* fix tests

* missing change

* remove caching logic again

* one more cache removal

* fix for bad arguments writing to the db

* get db from store

* fix wrong command in script

* fix return type of getText

Co-authored-by: mariopino <[email protected]>
Co-authored-by: Bitcoinera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbibla jbibla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default to gaia in GOPATH luniehq/lunie
Billy/574 e2e w no options luniehq/lunie
3 participants
@NodeGuy @faboweb @jbibla