Billy/574 e2e w no options #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree this is annoying but changing the environment is bad practice (it should be thought of as an immutable input). I think #784 is a better solution. |
Codecov Report
@@ Coverage Diff @@
## develop #797 +/- ##
========================================
Coverage 86.59% 86.59%
========================================
Files 96 96
Lines 1664 1664
Branches 94 94
========================================
Hits 1441 1441
Misses 207 207
Partials 16 16 |
|
changed this to only modify electron environment |
NodeGuy
approved these changes
Jun 6, 2018
faboweb
pushed a commit
that referenced
this pull request
Jun 2, 2020
* fetch emoney gas prices dynamically * changelog * rename terra_polling_interval to fees_...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #574
Description: e2e tests are annoying because they require flags for binary and node binary paths to be set. this should fix that and not break circle