Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show versions #886

Closed
faboweb opened this issue Jun 26, 2018 · 12 comments
Closed

Show versions #886

faboweb opened this issue Jun 26, 2018 · 12 comments
Labels
design-work-needed 🎨 issues that require design work before development

Comments

@faboweb
Copy link
Collaborator

faboweb commented Jun 26, 2018

UI Version: 0.7.0

Description:

Following up on #767 we may want a modal that shows the versions currently used in Voyager or incorporate these informations on the preferences page.

@faboweb faboweb added proposal design-work-needed 🎨 issues that require design work before development labels Jun 26, 2018
@nylira
Copy link
Contributor

nylira commented Jun 27, 2018

We have a lot of dependencies. Instead of a modal, let's make a very simple full page that lists all of our package.json dependencies.

@faboweb
Copy link
Collaborator Author

faboweb commented Jul 2, 2018

I would not show all the dependency versions. Just the Gaia/Tendermint/Voyager versions. Which versions would a user be interested in?

@okwme
Copy link
Contributor

okwme commented Jul 2, 2018

any inputs on these variations?
screenshot 2018-07-02 19 21 26
screenshot 2018-07-02 19 21 15
screenshot 2018-07-02 19 20 46
screenshot 2018-07-02 19 20 49

@okwme okwme mentioned this issue Jul 2, 2018
@faboweb
Copy link
Collaborator Author

faboweb commented Jul 3, 2018

Nice :)
I think the network already shows in the network indicator and is therefor doubled. What do you think?

@faboweb
Copy link
Collaborator Author

faboweb commented Jul 3, 2018

What about the Tendermint version?

@faboweb
Copy link
Collaborator Author

faboweb commented Jul 3, 2018

For the design I like the 2nd one the most as it looks the cleanest. But the popup also looks nice and maybe putting the versions on the preferences page mixes up too much content?

@nylira
Copy link
Contributor

nylira commented Jul 3, 2018

I think the popup is cleanest. But I wonder why the version shows 0.4.3. Good work.

@okwme
Copy link
Contributor

okwme commented Jul 3, 2018

Version were hard copy dummy
got real info in the popup, how's this:
screenshot 2018-07-03 15 40 33
screenshot 2018-07-03 15 40 36

@jbibla
Copy link
Collaborator

jbibla commented Jul 3, 2018

looks good!

maybe the left side should ay "Version information" and the button on the right could say "show versions" - as the buttons tend to contain a verb and the left side (description) is usually more descriptive 😄

@nylira
Copy link
Contributor

nylira commented Jul 4, 2018

For the text, let's do:

About Cosmos Voyager
=====
Voyager v0.7.0
Cosmos SDK v0.19.0

If the SDK is following semver, we don't need to show the user the git hash--that is extra visual noise they don't need.

@faboweb
Copy link
Collaborator Author

faboweb commented Jul 4, 2018

What about the Tendermint version?

@okwme
Copy link
Contributor

okwme commented Jul 4, 2018

@Fabo and I discussed Tendermint version and decided that because the tm version can be derived from Cosmos SDK version, and because there's no command available in gaiacli or gaiad right now to get the tendermint version that we skip it until it is requested.

screenshot 2018-07-04 10 55 11
screenshot 2018-07-04 10 55 14

@faboweb faboweb unassigned nylira and okwme Apr 1, 2019
faboweb added a commit that referenced this issue Jun 6, 2020
* trigger CI

* release-1.0.23

* Update CHANGELOG.md

Co-authored-by: Bitcoinera <[email protected]>
Co-authored-by: Release Lunie Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-work-needed 🎨 issues that require design work before development
Projects
None yet
Development

No branches or pull requests

4 participants