Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About Popup #907

Merged
merged 10 commits into from
Jul 4, 2018
Merged

About Popup #907

merged 10 commits into from
Jul 4, 2018

Conversation

okwme
Copy link
Contributor

@okwme okwme commented Jul 2, 2018

Closes #886

Description: variations of a solution to the About/Version info on preferences page
screenshot 2018-07-02 19 21 26
screenshot 2018-07-02 19 21 15
screenshot 2018-07-02 19 20 46
screenshot 2018-07-02 19 20 49

@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #907 into develop will increase coverage by 0.29%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop     #907      +/-   ##
===========================================
+ Coverage    94.42%   94.71%   +0.29%     
===========================================
  Files           79       79              
  Lines         1452     1457       +5     
  Branches        77       77              
===========================================
+ Hits          1371     1380       +9     
+ Misses          66       64       -2     
+ Partials        15       13       -2
Impacted Files Coverage Δ
app/src/renderer/components/common/TmModal.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/PagePreferences.vue 100% <100%> (+22.22%) ⬆️
app/src/renderer/vuex/modules/config.js 100% <100%> (ø) ⬆️

@okwme okwme changed the title WIP: About Popup About Popup Jul 4, 2018
@@ -3,6 +3,9 @@ import fs from "fs-extra"
let testRoot = "./test/unit/tmp/test_root/"

function mockGenesis() {
process.env.COSMOS_NETWORK = "./networks/gaiaiaiaiaiaia/"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XD

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😜

@faboweb faboweb merged commit e880aff into develop Jul 4, 2018
@faboweb faboweb deleted the billy/886-about-popup branch July 4, 2018 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants