-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable certificate store columns #294
Conversation
|
This is also breaking the |
Hey there, you're likely going to want to add the description column now that it's been added with #297 |
Hey @stgraber I've fixed both the I've also added in the description column as per your last comment. It appears the Thanks! |
|
Great, thanks. I've confirmed the description is displaying as expected. I should have some time tonight to figure out why the The |
@rhburt I took a quick look. I also used the opportunity to extract the test changes to a separate commit. Basically the issue here was an invocation of That kind of breakage can be a bit weird to debug as running the test in isolation wouldn't show the issue. |
Signed-off-by: Reid Hurlburt <[email protected]>
Signed-off-by: Reid Hurlburt <[email protected]>
Signed-off-by: Stéphane Graber <[email protected]>
Oops, sorry I got distracted by all of today's drama, PR looks great now! Thanks! |
Closes #250
I've adapted how variable columns are accomplished in
image list
to work forconfig trust list
.Contributing guidelines said to update the translations alongside changes to any CLI strings as well.