Add description field on certificate entries #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Documentation
|
presztak
force-pushed
the
certificate_description
branch
from
9e184fa
to
cb1857a
Compare
stgraber
reviewed
Dec 11, 2023
internal/server/db/cluster/update.go
Outdated
| // updateFromV69 adds description column to certificate. | ||
| func updateFromV69(ctx context.Context, tx *sql.Tx) error { | ||
| q := ` | ||
| ALTER TABLE certificates ADD COLUMN description TEXT NOT NULL; |
There was a problem hiding this comment.
This is going to fail to run on any Incus system that has a DB entry in the certificates table.
This is going to need a DEFAULT "" to avoid this problem.
There was a problem hiding this comment.
ahh, that's right. Fixed.
|
Looks good, just that small schema issue and it should be good to go. |
Signed-off-by: Piotr Resztak <[email protected]>
Signed-off-by: Piotr Resztak <[email protected]>
Signed-off-by: Piotr Resztak <[email protected]>
Signed-off-by: Piotr Resztak <[email protected]>
Signed-off-by: Piotr Resztak <[email protected]>
presztak
force-pushed
the
certificate_description
branch
from
cb1857a
to
ab98775
Compare
stgraber
approved these changes
Dec 11, 2023
|
Thanks @presztak! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds description field on certificate entries and possibility to modify description using API.
Closes #246