-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace environment variable for configuration injection #135
Comments
Environment variable substitution merged upstream: docker-flink/docker-flink#91 |
Is there a way we can make this backwards compatible? Otherwise this will break people's existing images. |
Yes, unfortunately it would break images if they were copied from the previous example. On the other hand, the operator will become compatible with the docker-flink images and custom cruft can just be deleted. Should we publish both environment variables for a while or just switch before going out of beta? |
Yeah, I think we would need to do something along those lines. Otherwise this is a breaking change that will be hard to manage for users. |
Environment variable
OPERATOR_FLINK_CONFIG
should be replaced withFLINK_PROPERTIES
to support the stock Flink Docker images.docker-flink/docker-flink#82
We should also update the example to use that image.
The text was updated successfully, but these errors were encountered: