-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordcount example to use docker-flink image #135 #136
Conversation
flinkVersion: "1.8" | ||
jarName: "wordcount-operator-example-1.0.0-SNAPSHOT.jar" | ||
parallelism: 3 | ||
parallelism: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert to 3 before merging.
@@ -7,25 +7,30 @@ metadata: | |||
labels: | |||
environment: development | |||
spec: | |||
image: docker.io/lyft/wordcount-operator-example:{sha} | |||
#image: docker.io/lyft/wordcount-operator-example:{sha} | |||
image: wordcount-operator-example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revert after publishing container.
elif [ "$COMMAND" = "local" ]; then | ||
echo "Starting local cluster" | ||
exec $(drop_privs_cmd) "$FLINK_HOME/bin/jobmanager.sh" start-foreground local | ||
#export FLINK_PROPERTIES=`echo "${OPERATOR_FLINK_CONFIG}" | envsubst` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm planning to propose the addition of envsubst in docker-flink as follow-up.
@anandswaminathan below the output from running the example locally: I also noticed that after the job is finished, deleting the application fails due to attempt to take a savepoint. That should probably be fixed separately.
|
@tweise Looks good. Can you also log into the job/taskmanager (You can |
@anandswaminathan here the appended config:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once test passes
@@ -8,23 +8,27 @@ metadata: | |||
environment: development | |||
spec: | |||
image: docker.io/lyft/wordcount-operator-example:{sha} | |||
deleteMode: None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job finishes and the operator tries to take a savepoint. That's a bug that needs to be fixed separately.
For the demo, the application should just be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it has a bounded input. We should probably fix that, as the operator doesn't (intentionally) support jobs that complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't see why the operator shouldn't support such jobs. Created #138 to follow up on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I mean any support currently in the operator is accidental; we haven't tested this use case or thought deeply about how to support it. Would be good to have better support but it's not a use case internally.
FYI, describe still does not present the URL, even when the job is RUNNING and I can access it via
|
No description provided.