-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wordcount example to use docker-flink image #135 #136
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,45 +1,10 @@ | ||
#!/bin/sh | ||
|
||
drop_privs_cmd() { | ||
if [ $(id -u) != 0 ]; then | ||
# Don't need to drop privs if EUID != 0 | ||
return | ||
elif [ -x /sbin/su-exec ]; then | ||
# Alpine | ||
echo su-exec | ||
else | ||
# Others | ||
echo gosu flink | ||
fi | ||
} | ||
|
||
# Add in extra configs set by the operator | ||
# Map config from FlinkK8sOperator to base container | ||
# https://github.com/lyft/flinkk8soperator/issues/135 | ||
# https://github.com/docker-flink/docker-flink/pull/91 | ||
if [ -n "$OPERATOR_FLINK_CONFIG" ]; then | ||
echo "$OPERATOR_FLINK_CONFIG" >> "/usr/local/flink-conf.yaml" | ||
fi | ||
|
||
envsubst < /usr/local/flink-conf.yaml > $FLINK_HOME/conf/flink-conf.yaml | ||
|
||
COMMAND=$@ | ||
|
||
if [ $# -lt 1 ]; then | ||
COMMAND="local" | ||
fi | ||
|
||
if [ "$COMMAND" = "help" ]; then | ||
echo "Usage: $(basename "$0") (jobmanager|taskmanager|local|help)" | ||
exit 0 | ||
elif [ "$FLINK_DEPLOYMENT_TYPE" = "jobmanager" ]; then | ||
echo "Starting Job Manager" | ||
echo "config file: " && grep '^[^\n#]' "$FLINK_HOME/conf/flink-conf.yaml" | ||
exec $(drop_privs_cmd) "$FLINK_HOME/bin/jobmanager.sh" start-foreground | ||
elif [ "$FLINK_DEPLOYMENT_TYPE" = "taskmanager" ]; then | ||
echo "Starting Task Manager" | ||
echo "config file: " && grep '^[^\n#]' "$FLINK_HOME/conf/flink-conf.yaml" | ||
exec $(drop_privs_cmd) "$FLINK_HOME/bin/taskmanager.sh" start-foreground | ||
elif [ "$COMMAND" = "local" ]; then | ||
echo "Starting local cluster" | ||
exec $(drop_privs_cmd) "$FLINK_HOME/bin/jobmanager.sh" start-foreground local | ||
export FLINK_PROPERTIES="`echo \"${OPERATOR_FLINK_CONFIG}\" | envsubst`" | ||
fi | ||
|
||
exec "$@" | ||
exec /docker-entrypoint.sh "$@" |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The job finishes and the operator tries to take a savepoint. That's a bug that needs to be fixed separately.
For the demo, the application should just be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, it has a bounded input. We should probably fix that, as the operator doesn't (intentionally) support jobs that complete.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually don't see why the operator shouldn't support such jobs. Created #138 to follow up on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I mean any support currently in the operator is accidental; we haven't tested this use case or thought deeply about how to support it. Would be good to have better support but it's not a use case internally.